1 bug fix in kernels.py - #4
Open
amna-ukaea wants to merge 3 commits into
Open
Conversation
…mesh_object method, but if none of the conditions are met, the variable remains undefined. Therefore, when you try to assign mesh to self.mesh_objects[name], it raises an UnboundLocalError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1) in ParsedAux in kernels.py there are many lines in the format string += f'variable={self.variable.name}\n', but one is written wrongly
before:
string += f'{self.function.str()}'
now:
string += f'function={self.function.str()}'
added "function=" so "function" is written to the file.
Also the same string written to file needs to be on separate lines, but one new line was missing
added new line in kernels.py because a new line was supposed to be there but wasn't_
before:
string += f'function={self.function.str()}
now:
string += f'function={self.function.str()}\n
before:
self.mesh_objects[name] = mesh
now:
mesh = None
if mesh is not None:
self.mesh_objects[name] = mesh