Repository navigation
ci: upload Stage 1 and the ESP Stage 2 as separately named artifacts - #142
Merged
RyanTheTide merged 1 commit intoNov 10, 2026
Merged
Conversation
RyanTheTide
reviewed
Nov 10, 2026
RyanTheTide
left a comment
Contributor
There was a problem hiding this comment.
CI is green on this head and both artifacts upload. The commit (629a1b1) has no Signed-off-by line; please amend it with git commit --amend -s and push.
The build job built only a CHAINLOADING=1 image and uploaded it as
"aura". That aura.bin is a Stage 1 image. Because the name did not
say so, it was taken for an ESP Stage 2, and tools/compose_stage2.py
then rejected it ("expected a bare ESP_STAGE2=1 Aura image").
Build both stages with the same flags. Upload Stage 1 as
"aura-stage1-chainloading" and the ESP_STAGE2=1 build as
"aura-esp-stage2". The README now lists the flags for each stage
beside the plain development build.
No source change. Nothing here was run on hardware.
Assisted-by: LLM
Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
techmore
force-pushed
the
ci/name-stage-artifacts
branch
from
November 10, 2026 11:22
629a1b1 to
6e55073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
buildjob builds only aCHAINLOADING=1image and uploads it under the generic nameaura. Thataura.binis a Stage 1 image, but nothing in the name says so. On 2026-11-08 the CI artifact for #113 (ac628dae…) was taken for an ESP Stage 2, andtools/compose_stage2.pyrejected it withexpected a bare ESP_STAGE2=1 Aura image.Change
make cleanin between.aura-stage1-chainloadingandaura-esp-stage2.docs/boot-options.md,docs/stage2-dtbs.mdandrelease.yml.There is no source change. This does not touch #113.
Testing
buildrun is the test. It must produce both artifacts.CHAINLOADING=1 ESP_STAGE2=1 EXTRA_CFLAGS="-Wstack-usage=2048 -Os"), which built cleanly with the same toolchain family.