Repository navigation
kboot: T8142: publish ANS's APCIe and the radio port's tables for the sleep controller - #272
Merged
DjDeveloperr merged 1 commit intoNov 17, 2026
Conversation
… sleep controller The T8142 sleep controller (aurora-silicon/linux#2043) brings ANS's half of the shared APCIe block back after a real sleep and trains the radio's port 0 again through its pcie-shared node. Copy iBoot's tables from /arm-io/apcie (axi2af, phy, phy-ip-pll, phy-ip-auspma) and its pci-bridge0 (apcie-config, pcie-rc, -gen3-shadow, -gen4-shadow) onto that node, bounded by its windows, as j813_n1.c applies them at boot. Nothing is published unless all eight are valid. Signed-off-by: Thomas Glanzmann <thomas@glanzmann.de>
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The T8142 sleep controller in aurora-silicon/linux#2043 brings ANS's half of the shared APCIe block back after a real sleep. It also retrains the radio's port 0. Both go through the controller's
pcie-sharednode, which needs iBoot's tables. Nothing publishes them on T8142. Without them the driver says "no PCIe tunables for ANS: suspend-to-RAM with it stopped will be refused" and "the radio's port can't be trained after a sleep". It then refuses every real sleep.This copies the tables onto the node the sleep controller's
apple,apciepoints at. They are the same tablesj813_n1.capplies at boot:/arm-io/apcie:apcie-axi2af,apcie-phy,apcie-phy-ip-pllandapcie-phy-ip-auspma(apple,tunable-axi2af,-phy,-phy-ip-pll,-phy-ip-auspma);pci-bridge0:apcie-config,pcie-rc,pcie-rc-gen3-shadowandpcie-rc-gen4-shadow(apple,tunable-radio-port,-radio-rc,-radio-rc-gen3,-radio-rc-gen4).Each table is bounded by its window in #2043's DT. All eight are checked before anything is written. If one is missing or malformed, nothing is published, and the driver keeps refusing as before. The step only runs when the DT has an
apple,t8142-sleepnode withapple,apcie. It does nothing if the tables are already there.Tested
CHAINLOADING=1 ESP_STAGE2=1 DEBUGUSB_PROXY=1. Clean under clang-format.The J813 sleep itself doesn't work yet; the details are in the J813 PR on #2043.
cc @Acelogic @DjDeveloperr @RyanTheTide @LiamRay10