Skip to content

kboot: end an ACIO tunable table at its first all-zero entry - #308

Closed
m0d16l14n1 wants to merge 1 commit into
aurora-silicon:mainfrom
m0d16l14n1:j815/acio-tunable-zero-end
Closed

m0d16l14n1 wants to merge 1 commit into
aurora-silicon:mainfrom
m0d16l14n1:j815/acio-tunable-zero-end

Conversation

@m0d16l14n1

Copy link
Copy Markdown
Contributor

Both display ADMACs on the J813 (and the J815, with the same ADT layout) lost their control tunables.

admac-dispextN-ced-ssw's ssw-tunables is 336 bytes: one real entry (offset 0, size 4, mask 1, value 1), then 13 all-zero entries. dt_append_acio_tunable() refused the size-0 entry, so neither apple,tunable-ced nor apple,tunable-ssw reached the DT. The log shows "ACIO tunable has invalid size 0" and "no ADT tunables for admac-dispext0-control".

Change: a table ends at its first all-zero entry.

Tested by gig3m on a J813 (aurora-silicon/linux#1806): with the change both tables are copied (apple,tunable-ced 168 bytes, apple,tunable-ssw 12 bytes). DP audio playback still underruns on its own; that is a separate problem.

🤖 Generated with Claude Code

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants