Repository navigation
kboot: end an ACIO tunable table at its first all-zero entry - #308
Closed
m0d16l14n1 wants to merge 1 commit into
Closed
m0d16l14n1 wants to merge 1 commit into
m0d16l14n1 wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both display ADMACs on the J813 (and the J815, with the same ADT layout) lost their control tunables.
admac-dispextN-ced-ssw'sssw-tunablesis 336 bytes: one real entry (offset 0, size 4, mask 1, value 1), then 13 all-zero entries.dt_append_acio_tunable()refused the size-0 entry, so neitherapple,tunable-cednorapple,tunable-sswreached the DT. The log shows "ACIO tunable has invalid size 0" and "no ADT tunables for admac-dispext0-control".Change: a table ends at its first all-zero entry.
Tested by gig3m on a J813 (aurora-silicon/linux#1806): with the change both tables are copied (
apple,tunable-ced168 bytes,apple,tunable-ssw12 bytes). DP audio playback still underruns on its own; that is a separate problem.🤖 Generated with Claude Code