You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
J616s USB4: ACIO port restart leaves the old XDomain registered; tbnet uses a freed control channel (Oops); control port wedges at boot #1318
J616s (fleet44, Stage 2 195b4260), USB4 cable on left back (ACIO0) to the M2, 11-09 21:48-21:58 (GPUTEMP lane). This is a third case of the problem in #1230, and it happens without a suspend.
Router control port wedges about 28 s after boot. The first thunderbolt-net login comes up and its paths are torn down. From then on route-0 config reads time out (timeout reading config space 0 from 0x10), DMA path activation fails with -110, and thunderbolt-net: failed to enable DMA paths. There was no s2idle, so thunderbolt: xdomain: do not redo lane bonding on a link that is still bonded (J616s s2idle, #1230) #1244 (no re-bond on resume) only removed the resume trigger.
The port restarts, but the old XDomain is still registered. ACIO0 is stopped ('Failed to shutdown M3 RTKit, continuing ACIO shutdown anyway') and started again (PHY asleep/up, firmware ready). The new domain's XDomain then fails with sysfs: cannot create duplicate filename '/bus/thunderbolt/devices/0-1' (tb_xdomain_state_work -> device_add). The old thunderbolt-net 0-1.0 also keeps running: 'failed to send ThunderboltIP response' repeats.
Oops.Unable to handle kernel paging request in queued_spin_lock_slowpath, via ring_work -> tbnet_login_response -> tb_cfg_request on a freed control channel. Kworkers are left in D state. This is the same lifetime bug as the ACIO unbind oops in J616s USB4: thunderbolt-net wedges after repeated s2idle; ACIO unbind oopses in tbnet_login_work #1230: stopping a port does not take the XDomain and its service (thunderbolt-net) down before the control channel goes.
After the sysrq reboot, the next boot died 17 s in, right after 'thunderbolt 0-1: new host found'. fleet45-kernel boots also show apple-dart 381a80000: translation fault SID:0 write CTE invalid.
Activity
thunderbolt: Unregister XDomains when the domain is removed