Repository navigation
drm/apple: m4: accept the J604 firmware's page-aligned D451 buffers - #1389
Merged
RyanTheTide merged 1 commit intoNov 10, 2026
Merged
Conversation
On the J604 (MacBook Pro 14-inch, M4) the internal DCP's 26.6.2 firmware asks D451 allocate_buffer for buffers with an alignment of 4096 as well as 4. The internal path accepts only 4, so the first such request fails the callback, the retained session is quarantined and appledrm does not bind: the panel stays on simpledrm. Let a panel profile accept an alignment that is a power of two up to a page on its internal DCP, which every buffer has, as the external DCPs' rule already does, and set it for the J604 only. Every other check of the qualified request stays as it is; nothing changes for the J713 or the J715. Tested on a J604 (26.6.2) with apple_dart.j713_dcp=1 and apple_dart.j713_display=1: the DCP starts, appledrm binds the panel at 3024x1964 and the desktop runs on it. Assisted-by: LLM Signed-off-by: Friedrich <261542475+aeries0x@users.noreply.github.com>
RyanTheTide
merged commit Nov 10, 2026
d6ec67a
into
aurora-silicon:integration/aurora
1 check passed
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On my J604 (MacBook Pro 14-inch, M4) the internal panel stays on simpledrm, even with
apple_dart.j713_dcp=1 apple_dart.j713_display=1. aura already hands the display over on the J604("M4 DCP firmware mappings published", "M4 native scanout diagnostic enabled with preserved SID0
mappings"), both display DARTs admit the inherited tables, and the DCP gets through warm RTKit adoption
to
DCPLink READY. Then the J604's 26.6.2 firmware asks D451 allocate_buffer for a buffer aligned to4096, the internal path accepts only an alignment of 4, and the session is quarantined:
This adds a panel profile flag,
alloc_page_align, set only for the J604: its internal DCP may also askfor an alignment that is a power of two up to a page, the rule the external DCPs already have. Every
other check of the qualified request (options 0x703, size, the NULL output flags) stays as it is. The
J713 and J715 profiles don't set it, so nothing changes for them.
Testing
J604 (Mac16,1), macOS 26.6.2 firmware, tethered RAM-only boots through aura/main 21a70e6e plus #137 and
#139, with
apple_dart.j713_dcp=1 apple_dart.j713_display=1on the command line:integration/aurorae220b4d without this commit: D451 refused as above, desktop on simpledrm.IOMFB startup complete: 317 callbacks, 3024x1964 at 804560 kHz,KMS scanout activated, appledrmfb on card1 (eDP-1 connected); the login screen and the desktop comeup on the panel through DCP, and G16 then registers and reaches READY.
integration/auroraad8751c, plus this commit: the same result. With atemporary log line (not part of this PR), the firmware's D451 requests during startup were all options
0x703 with the output flags 0/0/0: 14 x size 0x1000 align 4, 13 x size 0x1000 align 4096, 2 x size
0x40000 align 4. A DPMS off/on from Hyprland ran a full panel power cycle (
power on -> off, M3 down,power off -> on, backlight on again) and the desktop came back.The test builds also carried #1329 (G16 layout), #1367 (MTP) and local changes unrelated to the display
(read-only RTC/NVMEM, sound nodes off, the SMC power-off write limited). Tested on the J604 only; not
tested: sleep/resume, brightness, external displays.
Unrelated to this change but seen on every boot with the opt-in: the DCP DART's validation warns
Missing '#address-cells' in /soc/dcp@30ae00000(and#size-cells) fromof_n_addr_cells()inapple_dart_dcp_validate(), with and without this commit.Assisted-by: LLM