Repository navigation
arm64: dts: apple: t8142: lid angle sensor on J815 and J813 (on #1532) - #1805
Merged
DjDeveloperr merged 7 commits intoNov 17, 2026
Merged
DjDeveloperr merged 7 commits into
DjDeveloperr merged 7 commits into
Conversation
The T8142 AOP firmware announces the "las" lid angle service, as T6050's does. Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
The J815 AOP firmware announces "las": macOS 27.2 binds it on this machine as an AppleSPUHIDDevice with usage page 0x20 and usage 0x8a, the report aop_las decodes. Describe the service. The ADT's i2c1 "mogul-las" is the sensor's authentication chip, not the angle. On J815 the IIO device reads in_angl_raw 109 (scale pi/180), and it still reads after s2idle. Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
Contributor
|
J813 has the same service, and J813 (Mac17,3, 27.0 stub), integration/aurora 5d112b1 merged with #1532 at 0434a61:
How I tested: on the running system, without the node. I bound the driver to the service device by hand ( --- a/arch/arm64/boot/dts/apple/t8142-j813.dts
+++ b/arch/arm64/boot/dts/apple/t8142-j813.dts
@@ -135,6 +135,14 @@ &aop {
aop_als: als {
compatible = "apple,t8142-aop-als", "apple,aop-als";
};
+
+ /*
+ * Lid angle: the J813 AOP firmware announces a "las" service, as the
+ * J815's does, and aop_las reads the hinge angle from it.
+ */
+ aop_las: las {
+ compatible = "apple,t8142-aop-las", "apple,aop-las";
+ };
};Not tested: a read after s2idle with it bound. Assisted-by: Claude Fable 5.2 |
The J813 AOP firmware registers the same "las" service as the J815's, next to "als". Describe it, as on J815. gig3m tested this on a J813 (Mac17,3, 27.0 stub) by binding aop_las to the service device by hand. in_angl_scale reads 0.017453293, and in_angl_raw reads 107 and follows the lid (107, 53, 129, 23, 116). No extra AOP mailbox interrupts arrive while the lid is still. The node is gig3m's diff. It compiles but has not been booted yet. Link: aurora-silicon#1805 (comment) Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
Contributor
Author
m0d16l14n1
marked this pull request as ready for review
November 15, 2026 04:55
Contributor
Author
|
@DjDeveloperr out of draft, parent-first on #1532 (alias fix merged in). The lid angle follows the lid on the J815 (27.2 stub, checked by probing at several angles) and on @gig3m's J813 (his node is in 508b1cd). Please review. Assisted-by: Claude Opus 5.5 |
Keep only the three Air lid-angle patches on the merged parent tree. Signed-off-by: Diljit Singh <hey@djdev.me>
J514s and J516s already use the T6030, T6020 and generic compatible tuple. Document that exact list without changing the DTS or driver. Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
merged commit Nov 17, 2026
d4791aa
into
aurora-silicon:integration/aurora
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, stacked on #1532 (the J815 device tree; J815 only gets its
&aopnode there). The net change is the last three commits: m0d16l14n1/linux@c93ee62...m0d16l14n1:linux:j815/t8142-lid-angleapple,t8142-aop-las.lasunder&aop. The J815 AOP firmware announces a "las" service. macOS 27.2 on this machine binds it as an AppleSPUHIDDevice with usage page 0x20 and usage 0x8a, the reportaop_lasdecodes (as on T6050, arm64: dts: apple: t6050: Add the AOP lid angle sensor #1548). The ADT's i2c1mogul-lasis the sensor's authentication chip, not the angle. No driver change is needed:aop_lasmatchesapple,aop-las.lasnode, @gig3m's diff from the J813 run below. The J813 AOP registerslas.2.autonext toals.Tested on J815:
aop-sensors-lasprobes,in_angl_rawreads 109 within_angl_scalepi/180, and it still reads after s2idle.Tested on J813 (@gig3m, Mac17,3, 27.0 stub, driver bound by hand without the node):
in_angl_scale0.017453293, andin_angl_rawreads 107 and follows the lid (107, 53, 129, 23, 116). No extra AOP mailbox interrupts arrive while the lid is still. Not yet booted with the node itself, and not read after s2idle.CHECK_DTBS with
apple,aop-las.yamlis clean for J813 and J815. Both DTBs carry the node.Part of the J815 (MacBook Air 15-inch, M5, T8142) bring-up: board results are summarised in discussion #135. Tested on a J815 with a macOS 27.0 stub (firmware 27.0) through aura Stage 2.
Assisted-by: Claude Opus 5.5