Repository navigation
media: apple: prores: T8142 (M5) ProRes encoder - #1881
m0d16l14n1 wants to merge 3 commits into
Conversation
DjDeveloperr
left a comment
There was a problem hiding this comment.
Reviewed. This is an additive T8142 variant and APRI layout (four blocks, 38-row wrapper) with its own KUnit case. The T6041/T6050 variants, layouts and parser are unchanged, and the DT is J815-only. Approving.
Like #1880, it conflicts with the merged #1883 in t8142-j815.dts and t8142-peripherals.dtsi. Please rebase it after #1880 lands, and it merges once CI is green on the rebased head.
2cd5ad0 to
e3d9dad
Compare
|
@DjDeveloperr two changes since your approval, so another look, please:
W=1 + KUnit build clean, checkpatch --strict 0/0/0. The J815 is deployed without the file, so its next boot runs on the built-in rows; I'll post the result. Assisted-by: Claude Opus 5.5 |
7e59e4a to
507b4bc
Compare
|
Thanks for the rebase and the T8142 layout work. The variant, the APRI layout and the KUnit case look good. Three things before this goes in:
After that, a J704 or J813 owner can run the same 10 s encode on the SoC-level node. We can run no-regression rows on our A18 Pro (Neo) and M4 Pro, since the T6041 and T8140 paths share this code. |
The M5's ProRes encoder has T6050's five windows at the same offsets. Take the T8142 compatible beside T6050's. Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
The M5's ProRes encoder has T6050's five windows at the same offsets: core, the AXI-to-fabric wrapper, the SCODEC system window and the two SCODEC control pages. Its power-up is T6050's sequence with a shorter wrapper block: 82 system, 12 control, 80 core and 38 wrapper rows, then the driver's common ring, statistics and quantiser setup. Add the T8142 variant with its APRI layout (four blocks, a 38-row wrapper, 2592 bytes) and built-in rows, as T6041 and T6050 have. The ADT carries no tunables for the block, so the rows are the SoC's. The table names the statistics area sizes and shows the core rows' repeating block layout. apple/prores-t8142-init.bin stays optional and replaces the rows. Tested on a J815 with an init file holding the same rows: NV16 1920x1080 to ProRes 422, 10 frames, all decoded by ffmpeg, worst luma PSNR 66.4 dB. The KUnit suite passes, with a new T8142 layout case. Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
Describe the ProRes encoder of the T8142 SoC, so that every M5 machine gets it: - the SCODEC power state (pmgr device 336, +0x2c0); - the engine, with T6050's five windows; - the DART's power domain, register names and vm range (0x100_0000_0000, 0x300_0000_0000). Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
507b4bc to
4357676
Compare
|
@RyanTheTide thanks. New head 4357676, now three commits:
KUnit 18/18, Assisted-by: Claude Opus 5.5 |
|
J815 (MacBook Air 15" M5) run of the 300-frame ProRes test you asked for, on the current head 4357676 (built-in rows, no init file anywhere): Kernel: integration/aurora 0abc2f3 + this PR + the other T8142 PRs (#2383, #2325, #2328, #2384, #2385, #2330, #2194, #2221, #1906, …). The test looks for an init file in /lib/firmware, /usr/lib/firmware, /run and An earlier 10-frame run on the same boot gave 66.4 dB. No ProRes or DART lines in dmesg after the run. |
|
Thanks, that covers all three points. The block is on at SoC level, J704, J813 and J815 build cleanly here with the encoder enabled on each, and the 300-frame run is a clear pass: every frame decoded, worst luma PSNR 66.3 dB, no DART faults or timeouts. One small thing, optional: in Once CI is green on this head it is ready for another maintainer look. We will run the no-regression rows on our A18 Pro (Neo) and M4 Pro, and a J704 or J813 owner is welcome to repeat the 300-frame encode on the shared node. |
The M5 (T8142) ProRes encoder, on every T8142 machine.
apple,t8142-prores, beside T6050's, with the same five windows.APR_STATS_BYTES) and writes the core rows from 0x180 as their repeating 0x40-stride blocks, withAPR_BUF()packing each block's buffer start and length.apple/prores-t8142-init.binis optional; when present it replaces the built-in rows.Tested on J815: NV16 1920x1080 to ProRes 422, 10 frames, all decoded by ffmpeg, worst luma PSNR 66.4 dB. That run used an init file holding the same rows. The 300-frame run with the built-in rows and no init file, as requested, is in the next J815 test build.
Checks:
checkpatch --strictclean.dt_binding_checkclean onapple,prores.yaml.CHECK_DTBSoutput is the same as on integration/aurora 0abc2f3.Assisted-by: Claude Opus 5.5