Skip to content

arm64: dts: apple: t8142-j813: Add the cluster power gates - #1942

Closed
gig3m wants to merge 2 commits into
aurora-silicon:integration/aurorafrom
gig3m:j813/t8142-cluster-pwrgate
Closed

gig3m wants to merge 2 commits into
aurora-silicon:integration/aurorafrom
gig3m:j813/t8142-cluster-pwrgate

Conversation

@gig3m

@gig3m gig3m commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

iBoot leaves the P cluster's power-gate enable clear on T8142, so the boot core (P core 0) never powers down in WFI. T8132 and T8140 already describe these words for apple-cluster-pwrgate; this adds the T8142 compatible and the J813 node.

Tested on a J813 (MacBook Air 13" M5, fw 27.0), same kernel with and without the node, on battery, SMC PSTR:

  • PCPU_0's power state reads off in idle with the node, on without
  • screen off, idle: 2.72 W without, 2.54 W with
  • screen on, idle: 3.93 W without, 3.83 W with

All 10 cores come up, and the P cluster still reaches 4464 MHz under load after idling.

Not tested: J815, J704.

If this lands together with the DCP DPMS series, display-power@380724000 and power-gate@380724000 share a unit address (W=1 warning only; the words do not overlap).

@m0d16l14n1 the register layout is from your J815 tree. The same node should apply to the J815; I only have a J813 to test on.

Assisted-by: Claude Fable 5.2

@RyanTheTide

Copy link
Copy Markdown
Contributor

This conflicts with integration/aurora now that #1923 is in: both edit t8142-j813.dts. Please rebase. With the change applied, the DTBs of every board other than J813 build byte-identical.

T8142 has the same per-cluster power-gate enable words as T8132 and T8140.

Assisted-by: Claude Fable 5.2
Signed-off-by: Kyle Arrington <kyle@arrington.co>
iBoot leaves the boot core's power-gate enable (P core 0,
/arm-io/pmgr reg[34] + 0x60) clear on T8142, so the boot core never
powers down in WFI. The node lists the E and P clusters' first words,
which apple-cluster-pwrgate sets early in boot. T8132 and T8140
describe the same words; there they are enabled for deep sleep, here
for idle power.

Tested on a J813 (MacBook Air 13" M5, firmware 27.0), same kernel with
and without the node, on battery, SMC PSTR:
- PCPU_0's power state word reads off in idle with the node, on
  without it;
- screen off, idle: 2.72 W without, 2.54 W with (12 samples each);
- screen on, idle: 3.93 W without, 3.83 W with (3 samples each).
All 10 cores come up and the system runs as before.

The register layout is from m0d16l14n1's J815 sleep work
(m0d16l14n1#1).

Assisted-by: Claude Fable 5.2
Signed-off-by: Kyle Arrington <kyle@arrington.co>
@gig3m

gig3m commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Closing: #2135 carried this into integration/aurora. The J813 cluster_pwrgate node (t8142-j813.dts, power-gate@380724000) and the apple,t8142-cluster-pwrgate binding are both there now.

🤖 Generated with Claude Code

@gig3m gig3m closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants