Repository navigation
arm64: dts: apple: t6050-j714s: let userspace set the fan speeds - #1944
Merged
DjDeveloperr merged 1 commit intoNov 16, 2026
Merged
DjDeveloperr merged 1 commit into
DjDeveloperr merged 1 commit into
Conversation
Isaac-Duarte
force-pushed
the
j714s/fan-manual-control
branch
from
November 15, 2026 02:32
36df945 to
7952426
Compare
Mark both J714s fans apple,fan-manual-control, as the M4 Pro/Max MacBook Pros and the J704 already are, so fanX_target is writable without the unsafe fan_control module parameter, for userspace fan control such as a custom fan curve. The SMC still drives the fans until userspace writes a target, and writing 0 hands a fan back to the firmware. The M5 GPU governor already sets these fans through the same manual mode; a userspace target takes a fan over from it until 0 is written. J716s and J775D are left as they are until their fans are tested the same way. Tested on J714s (7.3.0-36.n1usb) with its installed device tree plus this property and fan_control=N: both fanX_target are 0644, the kernel is not tainted, fan 1 set to 4000 rpm ran at 3996 rpm and returned to firmware control after 0 was written, with no macsmc-hwmon warnings. Both fans are handed back the same way: after a userspace curve that had them at 7833 and 7811 rpm let go, both followed the firmware curve again, idling at 0 rpm and ramping under the next load to 3816/4114, then 4952/5347 rpm. Signed-off-by: Isaac Duarte <31712685+Isaac-Duarte@users.noreply.github.com>
Isaac-Duarte
force-pushed
the
j714s/fan-manual-control
branch
from
November 15, 2026 15:00
7952426 to
d71ab67
Compare
Isaac-Duarte
marked this pull request as ready for review
November 15, 2026 15:00
Contributor
|
Test report from a second J714s (MacBook Pro 14", M5 Pro), in case it helps review.
Thanks for this one. 🤖 Generated with Claude Code |
Isaac-Duarte
force-pushed
the
j714s/fan-manual-control
branch
from
November 15, 2026 20:29
d71ab67 to
7a479d4
Compare
DjDeveloperr
merged commit Nov 16, 2026
4db2f2f
into
aurora-silicon:integration/aurora
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark both J714s (M5 Pro) fans
apple,fan-manual-control, as the M4 Pro/Max MacBook Pros and the J704 already are, sofanX_targetis writable without the unsafefan_controlmodule parameter. This is for userspace fan control, such as a custom fan curve.Nothing changes until userspace writes a target: the SMC keeps driving the fans, and writing 0 hands a fan back to the firmware. This stays within #670's policy (host fan writes only for explicit user targets). The M5 GPU governor already sets these fans through the same manual mode; a userspace target takes a fan over from it until 0 is written.
Testing
On the J714s (7.3.0-36.n1usb), booted with its installed device tree plus this property and
fan_control=N:fanX_targetare 0644 and the property is present on both fan nodes in/proc/device-tree;Even with #1950, the SMC's fan ceiling (
fRMX) stays at 4950 rpm (the fans' maximum is 7826 rpm): under firmware control the post-#1950 run peaked at 4973 rpm on fan 1 and 5410 rpm on fan 2, with TCMb at 110.6 C. Only a host target can use the top third of the range.Earlier revisions of this PR carried benchmarks taken before #1950; they were dropped because #1950 fixed that slowdown.
J716s and J775D, which share the T6050 SMC, are left as they are until their fans are tested the same way.