Repository navigation
Conversation
J716C does not require an entry-signal event on a tiling kick. Avoid the redundant firmware round trip, matching the already-qualified zero-event form used by candidate 44 on this board. Keep the event on other M5 variants. A fresh J775c boot with upstream Mesa B reduced render submit time from 257.754 to 244.798 us (-5.03%); opaque and blended fill were unchanged. In the final two-patch series, render measured 242.033 us/submit. The final J775c no-retry gate passed alone6 90/90 and synchronization 2880/2880. Synchronization2 recorded 49144 Pass, 32467 NotSupported, 3 DeviceLost and 3 Crash, improving the upstream baseline of 49109 Pass, 31 Fail, 6 DeviceLost, 3 Crash and 1 ResourceError. Signed-off-by: Satya Benson <satya@benson.earth>
An installed J716C render pair with another pass in flight needs no new queue configuration, lead command, or item-ring notification. Keep the previous item targets and publish only the new kick through the existing host-port transaction in that steady state. Retain the ordinary item windows for first use, drained restarts, rebinds, priority changes, configuration updates, and lead commands. Zero-length retirement windows still retain pass stamps, pool accounting, job-list state, and every other completion witness. On a fresh J775c boot with upstream Mesa B, the two-patch series measured 79.792 us opaque fill, 306.905 us blended fill, 242.033 us render, and 211.089 us/queue hop. A separate fresh boot of this stage measured 230.645 us render; both runs improve on the 244.798 us tiling-only result. The no-retry gate passed alone6 90/90 and synchronization 2880/2880. Synchronization2 recorded 49144 Pass, 32467 NotSupported, 3 DeviceLost and 3 Crash, improving the upstream baseline of 49109 Pass, 31 Fail, 6 DeviceLost, 3 Crash and 1 ResourceError. Signed-off-by: Satya Benson <satya@benson.earth>
|
Thanks for the careful measurements and the exact tested composition. We usually enable an improvement wherever the hardware supports it, rather than on the board it was qualified on. Here both changes are limited to M5 parts with four clusters:
The comments justify this with "qualified on this board", not with a hardware difference. The redundant entry-signal event and the extra inner notification look like firmware protocol behaviour that the M5 Pro, the M5 Ultra and possibly the A18 Pro share. Could you either make both the default for every G17 configuration that uses this kick format, or explain in a comment what in the hardware or firmware differs on the other configurations? If you widen it, we can run render rows on our A18 Pro and M4 Pro. |
Use the GPU ID-selected firmware configuration to opt into ungated tiling kicks and host-port-only publication for retained render pairs. The G17C image supports both forms. Keep the established publication for G17S, G17D and the common 26A428 interface pending qualification. Signed-off-by: Satya Benson <satya@benson.earth> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Claude Fable 5.2 on @satchlj's behalf
|
|
Thanks for c857ff4. Selecting the host-only kicks from the firmware table, with the comment naming the interface differences on the other configurations, covers the point we raised. The G17C render row on this head is the remaining item; the red host-tests job failed in apt (network), so a re-run should clear it. |
|
Claude Opus 5.5 on @satchlj's behalf. J775c (Mac Studio M5 Max, G17C) render row for this head, as asked. Firmware 27.0 / 26A428. Result: this PR does not slow rendering, and does not regress anything we measured. Raster submissions are equal or 3–23% faster than its base. Method: base
Separate from this PR, and reported here because it showed up in this row: on both base and head the GPU executes the same workloads much more slowly than on our older default kernel on this machine (for example 389.7 against 165.5 µs per submission at render.heavy QD1, and GPU time barely falls with queue depth where it falls sharply on the old kernel). That fits a GPU performance state that does not rise under load on current trees, but we could not read the clock during the runs ( |
|
Thanks for the J775c row on c857ff4. Equal GPU time with 3-23% lower time per submission and no faults is what we hoped to see; once the queued check finishes this is ready for the next step. |
|
Claude Opus 5.5 on @satchlj's behalf: follow-up to the J775c (lobata) row. The slowdown in the base is fixed by #2080 (a250d9c), which landed after this PR's base. J775c confirms it: with the controller defaults applied, render.heavy GPU time goes from 389.7 to 83.5 µs at QD1 and from 306.5 to 64.8 µs at QD8. This PR itself showed no slowdown relative to its base. |
Claude Fable 5.2 on @satchlj's behalf.
Summary
This is a two-commit J716C render-path series:
The source guard is deliberately narrow: the path must be M5, not J813, and the selected board must have four clusters. In the current T6050 table that is the J716C M5 Max/G17C configuration; J714 M5 Pro, J775D M5 Ultra, and J813 M5 do not satisfy it.
Performance
Each benchmark cell was a fresh boot and used 15 independent processes per workload, pinned to CPU 12, with timestamps disabled, 200 ms warm-up, a 3 s measurement window, and alternating test order. Userspace was a private per-process Mesa/ICD selection with no system installation. The upstream Mesa B base was
b6c070c5d611; the final two-commit row useda7e10e986ed, whose unrelated compute-tail declaration remains RFC and is not part of this PR.The tiling commit alone reduced render time from 257.7541 to 244.7980 us/submit (-5.03%); the final composition measured 242.0331 us/submit. Opaque and blended fill were unchanged. Queue hop has no intended path change and no supported improvement here; the final 211.0892 versus 207.0393 us/hop movement is +1.96%. All 60 final benchmark processes succeeded.
Exact hardware-tested composition
The hardware run was on one J775c Mac Studio with an M5 Max (G17C), using fresh boots. Its kernel composition was:
integration/aurorafc050503ffcd;0075a007a507and PR PCI: apple: mask Clock PM before enabling adopted T6050 endpoints #1618 atccdd14ad5493, combined as62dc87119907, solely to make this machine boot;ca6323daa6e8;3998a081f56b, tree484a77acaea42b066a0bba51eda791ede846f035;eb44e713b1d1, with the same tree.PR #1618, PR #1619, and the name shim are not in this pull request.
The current integration tip is still
fc050503ffcd. Cherry-picking the two review commits produceda1efa1537025and000b48471371;git range-diffreports both commits as identical, and the affected G17 parent files matched byte-for-byte. There were no conflict resolutions or semantic/context edits. The PR branch itself was not booted; the hardware evidence above applies to the exact tested composition.Stability
The final fresh-boot, no-retry gate produced:
The aggregate final gate had 35 more Pass rows and 35 fewer loss rows, but case identity was not monotone: one baseline aggregate run had five cases pass that became three DeviceLost and two Crash rows in the final run, while 40 baseline loss rows recovered. These commits are not claimed to fix those cases.
Each moved case was then rerun ten times alone on each kernel and ten times in its original 200-case shard alongside five concurrent 200-case shards:
The isolated outcomes were identical between kernels. Under repeated six-shard load the two-commit tree was no worse in any case and better in two observed cells. This supports treating the five aggregate movements as pre-existing context/load-sensitive instability, not a regression or repair attributable to this series.
Scope and checks
Only J775c hardware was run. No J714/M5 Pro, J775D/M5 Ultra, J813/M5, or other J716C/M5 Max machine was tested. The source gate affects every current T6050 configuration that selects the four-cluster J716C board, even though the hardware evidence is from J775c only.
CONFIG_DRM_ASAHI=yandCONFIG_DRM_ASAHI_M5=yafterolddefconfigunder the builder toolchain;W=1build:drivers/gpu/drm/asahi/asahi_core.oand the fulldrivers/gpu/drm/asahi/directory aggregate built successfully.🤖 Generated with Claude Code