Repository navigation
Conversation
|
Thanks for chasing the 60 fps pacing on the T6030 ProMotion panel. That's a real improvement. Two things don't fit how we usually do this. Both behaviours sit behind new module parameters that default to off ( The driver already has per-board panel data for this: We can run pacing rows on our M1 Pro, M2, M4 Pro and A18 Pro if the early flip becomes the default. |
14.7 firmware on the T6030 ProMotion panel completes swaps every second refresh: with the swap record's presentation timing words all zero, swaps complete 16.7 ms apart even though the panel scans out at 120 Hz, so compositors pace everything at 60 fps (omacom/linux-aurora aurora-silicon#31). Set the existing per-board .swap_timestamps flag on the T6030 record. dcp_v14_swap_locked() then stamps the three presentation timing words (offsets 0x00, 0x08 and 0x30, as on the 12.x/13.x/26.6 paths) through dcp_v14_swap_timestamps(). With the target long past, the firmware presents each swap at the next refresh, i.e. at 120 Hz. Report an internal panel's flip before dcp_v14_present() instead of after it. dcp_v14_swap() blocks until the firmware completes the swap, so the compositor could not start its next frame until then. The next commit still waits for this swap (v14->lock and the CRTC commit dependencies), and displaced framebuffers stay pinned until the swap completes, so nothing is freed while the firmware may still scan it. A 3-buffer swapchain renders into the buffer from two flips back, which is already off screen. This is not board-specific and now applies to every internal 14.x panel; external processors keep their present path. On j514s (MacBook Pro 14", M3 Pro, T6030) with GNOME/mutter 50.6, stock paces everything at ~60 fps while the panel reports 120 Hz; with these changes UFO tester and visual checks confirm ~120 fps, stable across several boots with no GPU faults, flip failures or display errors. The swap timestamps were also validated on j516s (omacom/linux-aurora aurora-silicon#31). The early flip has only been tested on T6030. Assisted-by: LLM
4cf4a44 to
0136657
Compare
|
Thanks — reworked along those lines.
Only j514s (M3 Pro) has been tested: still ~120 fps with no faults. The KUnit change is compile-checked only (my build config has KUNIT off). Since the early flip is now the default on all internal v14 panels, your offered pacing rows on M1 Pro, M2, M4 Pro and A18 Pro would be very welcome. Assisted-by: DeepSeek v4.1 Flash |
|
Thanks for the rework: |
The 14.x firmware on the T6030 ProMotion panel completes swaps every second refresh: the presentation timing words in the swap record are all zero on the 14.x path, so the panel scans out at 120 Hz but everything is paced at 60 fps (omacom/linux-aurora #31, where the original change was posted and validated on j516s).
Two module parameters, both default off:
t6030_swap_timestampsstamps the three presentation timing words (0x00/0x08/0x30, the same offsets as on the 12.x/13.x/26.6 paths) on T6030 swaps. Reuses the tree's existingdcp_v14_swap_timestamps()(J613/25G83), which writes exactly these words.t6030_early_flipreports the page flip beforedcp_v14_present()instead of after the blocking swap, so the compositor is not serialized behind the swap round trip. Opt-in, because a two-buffer client with direct scanout could see a released buffer early.Tested on j514s (MacBook Pro 14", M3 Pro), GNOME/mutter 50.6 on Wayland, kernel built from this tree: stock paces everything at ~60 fps while the panel reports 120 Hz; with both parameters on, panel and apps run at ~120 fps (UFO tester in Firefox and visually), stable across several boots with no GPU faults, flip failures or display errors.
Companion PR for the 14.7 panel colour fix (omacom/linux-aurora #308): #1970
Assisted-by: GLM 5.3 Flash