Repository navigation
arm64: dts: apple: t6050-j714s: Add the left-front router's DP IN interrupts - #2002
Closed
Isaac-Duarte wants to merge 1 commit into
Closed
Isaac-Duarte wants to merge 1 commit into
Isaac-Duarte wants to merge 1 commit into
Conversation
…errupts The left-front port's USB4 router (acio1) came with the port's USB4 support, but without the DP IN interrupts that the right port's router (acio2) has. With no "dpinN" interrupt, the router driver polls a mapped DP IN's status every 20 ms instead; the interrupt and the poll run the same handler. This is not a functional fix: with the interrupts, hot plug and IRQ_HPD events arrive without the up to 20 ms poll delay, and there is no idle poll per mapped DP IN. Give acio1 the four DP IN interrupts, as acio2 has. The numbers are those of atc1-dpin0..3 in the T6050 inventory and of J716c's acio1, and follow acio2's, 32 lower like the rest of the router's interrupts. The DP IN blocks there sit at the offsets the driver maps from the router's "rc" region. The display side is already in place: dcpext0 and dcpext2 have routes to this port with its DP IN crossbar controls (typec1-dpin0..3 on atc1_dpxbar). Say in the file's header that the left-front port carries DP tunnels too. Signed-off-by: Isaac Duarte <31712685+Isaac-Duarte@users.noreply.github.com>
Isaac-Duarte
force-pushed
the
j714s/left-dock-dpin
branch
from
November 15, 2026 15:12
704374d to
3009996
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One commit, one file (
arch/arm64/boot/dts/apple/t6050-j714s-display.dtsi), J714s only.&acio1(the left-front port's USB4 router, added in arm64: dts: apple: t6050-j714s: Add the left-front port's USB4 router #1791) gets its four DP IN interrupts,dpin0..dpin3: AIC 1635, 1636, 1641, 1642. They sit next to&acio2's, in the same form.Why
#1791 described acio1 without the DP IN interrupts that acio2 has, so the left-front router doesn't match the right one or the T6050 inventory.
This is not a functional fix.
apple_cio_probe()looks updpinNwithplatform_get_irq_byname_optional(). With no line, a mapped DP IN is polled every 20 ms (APPLE_DPIN_POLL_MS). The IRQ thread and the poll both callapple_dpin_irq_dispatch(), and are started and stopped together (apple_dpin_irq_start()/_stop()).c->irqisn't used anywhere else. With the interrupts:Where the values come from:
atc1_dpin0..3int6050-peripherals.dtsi(the T6050 inventory).t6050-j716c-left-usb4.dtsi).rcregion (APPLE_DPIN_OFFSET0x390000 +apple_dpin_offsets[]).typec-routestotypec1with thetypec1-dpin0..3controls onatc1_dpxbar. The router finds that connector through itsport@1endpoint (typec1port@3).There is no DT binding for
apple,t6050-usb4-acioin the tree, so no schema covers these properties. acio2 uses the same names.Separately, there's an earlier report that a dock's displays stay dark on the left-front port. It's unverified, with no logs, and given the polling above this change isn't expected to fix it.
Tested
Not run on hardware. Only build checks:
t6050-j714s.dtbbuilt at the base (fef1b4c8d6) and at this head with cpp + dtc 1.8.1, using kbuild's include paths. Both builds have no dtc warnings.dtc -I dtb -O dtsshows that the only difference is inacio@2a9ac0000:interrupts = <0 0 0x663 4>, <0 0 0x664 4>, <0 0 0x669 4>, <0 0 0x66a 4>and the fourinterrupt-names.makewasn't usable here: my worktree is a sparse checkout, withoutscripts/or the Kconfig tree.CHECK_DTBSwas not run. No binding covers the acio node anyway.To run before merge
2a9ac0000.acio-dpinNlines in/proc/interruptscount up on hot plug, and displays behave as before (or better). If displays stay dark, these driver messages say why:no Type-C connector,no display pipeline free,waiting for display driver/firmware readiness,DP tunnel setup failed.