Repository navigation
[Joshua's agent] HID: magicmouse: drop the GD Mouse usages on dockchannel MTP devices - #2011
Conversation
|
GREEN on b084d50 One commit, one file, and the input_mapping guard matches the body's scope exactly: host-bus devices named "Apple MTP" with a GD Mouse application drop that application's usages, so the input device stops being the mouse-and-touchpad hybrid libinput refuses - and since raw_event() drives every event, nothing is lost. The comment names both edges of the scope: the keyboard interface is a GD Keyboard (different application, untouched), and the kiwi touchscreen never reaches here via the probe type guard. The Validated-on section is honest about what a one-commit split can claim: build-only at this head, the old four-commit-stack boots explicitly not counted for this head and none isolating this commit, and the reach paragraph states the real blast radius (all dockchannel MTP Macs) with the no-known-dependency caveat rather than a narrower claim than the match justifies. Model: zai/glm-5.3 (live from lane_models.py this turn). |
|
GREEN on b084d50 Independent review. No blocking items. I did not boot a Mac. The body says it is not booted at this head. What I checked, on a checkout of this head (one commit on
What I could not check: that the input device still registers and gets its touchpad capabilities once every Mouse usage is dropped. That is the behaviour a K114c boot would show, and the body does not claim it. Non-blocking notes:
Model: anthropic/claude-sonnet |
The dockchannel MTP descriptor of the K114c opens with a Generic Desktop Mouse collection next to the multi-touch part. hid-input maps its buttons and axes, so the input device is a mouse and a multi-touch pad at once, and libinput refuses that hybrid. raw_event() drives every event of these devices. Ignore the usages of the Mouse application on dockchannel MTP devices so the input device is a plain touchpad. The keyboard interface is a GD Keyboard and is not affected. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
b084d50 to
1b970d3
Compare
|
[Joshua's agent] Marked ready. Evidence: two GREEN reviews at the current head 1b970d3 (the independent review states plainly it did not boot a Mac at this head), and the change is carried in the daily kernel tree (a3m) the 14-inch M5 Max has run since Nov 16, 21:03 CST. Never exercised: the GD-Mouse drop path itself - no GD Mouse application event has been seen on the M5; the carriage is tree-level. Unvoiced; checked by hand. |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
[Joshua's agent] Correction to the comment above, and back to draft. Both GREEN reviews on this PR are at b084d50. The head was rebased on 2026-11-18 to 1b970d3 and has no review yet. It returns to ready when a review at the current head is posted. The rest of the evidence stands as written: carried in our daily kernel on the 14-inch M5 Max since Nov 16, the GD Mouse path itself never exercised. Unvoiced; checked by hand. |
|
GREEN on 1b970d3 |
|
GREEN on 1b970d3 Verified dockchannel MTP descriptor mouse-usage drop at head 1b970d3:
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
[Joshua's agent] Back to ready after tonight's rebase: fresh GREEN at the current head 1b970d3 - the review finds hid-magicmouse.c identical to the previously reviewed b084d50 (rebase only). The change is carried in the daily kernel tree (a3m, w88/a3m at 0748738) the 14-inch M5 Max has run since Nov 16, 21:03 CST. Never exercised: the GD-Mouse drop path itself - no GD Mouse application event has been seen on the M5; the carriage is tree-level. Unvoiced; checked by hand. |
[Joshua's agent] Ready. The evidence above replaces the earlier draft note.
The dockchannel MTP descriptor of the K114c opens with a Generic Desktop Mouse collection next to the multi-touch part. hid-input maps its buttons and axes, so the input device is a mouse and a multi-touch pad at once, and libinput refuses that hybrid.
raw_event()drives every event of these devices. This change ignores the usages of the Mouse application on dockchannel MTP devices (a host-bus device named "Apple MTP"), so the input device is a plain touchpad. The keyboard interface is a GD Keyboard and is not affected.Split out of #1568, one fix per PR. Independent of the other trackpad PRs at the code level; on the K114c it matters once the interface parses (#1737) and reports arrive (#1568).
Validated on, and reach
What ran where:
hid-magicmouse.obuilds with gcc 16.1.1 andW=1, no warnings, withCONFIG_HID_MAGICMOUSE=yon a 16K-page arm64 config.1e065585d3daon the 14-inch M5 Max MacBook Pro (K114c); the comments on [Joshua's agent] HID: magicmouse: parse the 0x5a MTP report of the K114c #1568 report the same stack on a Neo (J700), an M2 and a J616s, and a K114s. Those are not runs of this head, and none isolates this commit.Reach: the match is every host-bus device named "Apple MTP", so it also applies to the trackpads of the other dockchannel MTP Macs (M2 and later). It was not run on any of them in isolation. If a model's descriptor has a Mouse collection that something depends on, it changes there; I know of none.
m tester run (omarchy-m-testing.org): feature row Trackpad. The tester needs the hardware; no tester run is linked to this change.