Repository navigation
tools: apple-dcp: follow #1930's tunnel-watching link wait - #2042
Closed
DjDeveloperr wants to merge 1 commit into
Closed
DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
linux#1930 has dcp_dptx_connect_raw() wait for the link configuration through dcp_dptx_wait_linkcfg(), which on T6050 also ends the wait once the Thunderbolt DP tunnel feeding the port has gone. The lifecycle fixture that pastes the production connect (fast-replug-bounce) did not have the helper, so the unit no longer built. When the pasted connect calls it, the fixture now pastes the production dcp_dptx_wait_linkcfg() and dcp_watches_tunnel_withdrawal() as well. The fixture's machine is the H17P one, which does not watch the tunnel, so the wait is the single wait for the link configuration as before; the tunnel check is a stub that fails the case if it is ever reached. On a tree without #1930 nothing changes. Signed-off-by: Diljit Singh <hey@djdev.me>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host-test harness update for #1930 ("stop waiting for a link on a DP tunnel that went"). It touches only
tools/and changes no production code.#1930 has
dcp_dptx_connect_raw()wait for the link configuration through a newdcp_dptx_wait_linkcfg(). On T6050, that wait also ends once the Thunderbolt DP tunnel feeding the port has gone. The apple-dcp lifecycle fixturefast-replug-bouncepastes the production connect, but it didn't have the new helper, so with #1930 the unit no longer built:The change: when the pasted connect calls the helper, the fixture now also pastes the production
dcp_dptx_wait_linkcfg()anddcp_watches_tunnel_withdrawal().Checked in the CI host-test container (apple-dcp, 88 cases):
fast-replug-bounceonly.Merge order: this, then #1930.
🤖 Generated with Claude Code