Skip to content

tools: apple-dcp: follow #1930's tunnel-watching link wait - #2042

Closed
DjDeveloperr wants to merge 1 commit into
integration/aurorafrom
djdev/host-tests-1930
Closed

DjDeveloperr wants to merge 1 commit into
integration/aurorafrom
djdev/host-tests-1930

Conversation

@DjDeveloperr

Copy link
Copy Markdown
Contributor

Host-test harness update for #1930 ("stop waiting for a link on a DP tunnel that went"). It touches only tools/ and changes no production code.

#1930 has dcp_dptx_connect_raw() wait for the link configuration through a new dcp_dptx_wait_linkcfg(). On T6050, that wait also ends once the Thunderbolt DP tunnel feeding the port has gone. The apple-dcp lifecycle fixture fast-replug-bounce pastes the production connect, but it didn't have the new helper, so with #1930 the unit no longer built:

host.c: error: call to undeclared function 'dcp_dptx_wait_linkcfg'
host.c: error: call to undeclared function 'dcp_watches_tunnel_withdrawal'

The change: when the pasted connect calls the helper, the fixture now also pastes the production dcp_dptx_wait_linkcfg() and dcp_watches_tunnel_withdrawal().

Checked in the CI host-test container (apple-dcp, 88 cases):

Merge order: this, then #1930.

🤖 Generated with Claude Code

linux#1930 has dcp_dptx_connect_raw() wait for the link configuration
through dcp_dptx_wait_linkcfg(), which on T6050 also ends the wait once
the Thunderbolt DP tunnel feeding the port has gone. The lifecycle
fixture that pastes the production connect (fast-replug-bounce) did not
have the helper, so the unit no longer built.

When the pasted connect calls it, the fixture now pastes the production
dcp_dptx_wait_linkcfg() and dcp_watches_tunnel_withdrawal() as well. The
fixture's machine is the H17P one, which does not watch the tunnel, so
the wait is the single wait for the link configuration as before; the
tunnel check is a stub that fails the case if it is ever reached. On a
tree without #1930 nothing changes.

Signed-off-by: Diljit Singh <hey@djdev.me>
@DjDeveloperr

Copy link
Copy Markdown
Contributor Author

Closing: Isaac fixed the same fixture in #1930 itself (2865b4e), and that head's host tests are green. This one is no longer needed.

@DjDeveloperr
DjDeveloperr deleted the djdev/host-tests-1930 branch November 16, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant