Repository navigation
soc: apple: sep: Admit the K114s to the T6050 profile - #2115
chrisohearn wants to merge 1 commit into
Conversation
The K114s (MacBook Pro 14-inch, M5 Pro, OLED; Mac17,13) ADT describes the J714s's SEP: iop-sep at 0x502600000 and 0x502050000 (interrupts 533 to 536), dart-sep at 0x500b80000 with vm-base-0 0x10000004000 and vm-size-0 0xffff0000, and the Mesa sensor (sensor-id 0x3356, V3) on spi2 at 0x505108000, 8 MHz, powered by nub-gpio0 pin 21 with data ready on AP GPIO 138. Those are the values aurora-silicon#1587 validated on the J714s and aurora-silicon#1649 admitted for the K116s, so the K114s takes the T6050 profile as the K116s does. With the profile and a tree that enables the SEP and the sensor, the driver attaches on a K114s read-only (xart_writes=0 provision_keybag=0): warm bootstrap, 13 endpoints, key store open, hwrng registered, one APFS-resolved .gl extent with 11 valid records. Link: aurora-silicon#1649 Assisted-by: LLM Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: chrisohearn <137103567+chrisohearn@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…176) * Touch ID works on the K114s: trial, enrolment and PAM recorded (#49) docs/r3-touchid.md records phases 3 to 7 of 2026-11-16: the unattended trial boot, the read-only load, the backups (one off the Mac), the promoted Touch ID Stage 2, the keybag (guard level 1, no xART write), enrolment of the right index, match and no-match, the restore after a reboot, and sudo, polkit and the lock screen through Omarchy's own PAM setup. The upstream profile line is aurora-silicon/linux#2115. README and the matrix row say working; macOS Touch ID is the owner's check at the next macOS boot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Touch ID record: keep the macOS check open and claim only what was tested Review of #176: phases 5 and 6 stay open for the macOS boot check, and phase 6 says the enrolment was restored without re-enrolling. Only the keybag creation left xART unwritten; enrolment and matching updated one shared root record. sudo and the lock screen are owner-tested, polkit is configured but untried. The undo runs as root and removes the new polkit-1 file. The read-only check expects the 12 endpoints macOS lists plus srep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for checking the K114s ADT so carefully, and for the read-only-first test sequence. This adds The branch also needs a rebase. We can run no-regression rows on our other Macs if that helps. |
|
A follow-up to the earlier note on the board list. We are changing What the K114s still lacks at the current tip is the device tree: in Your hardware results already cover most of the row. At the new head we would ask for:
Until that change is merged, keep the |
|
A short follow-up: the change to pick the SEP profile by SoC is now #2311. With it, the One more K114s row, for thermal (PMP): the ADT |
Written by Claude (an AI agent) working for the owner of a K114s and posted from the owner's account at his direction.
The K114s (MacBook Pro 14-inch, M5 Pro, OLED; Mac17,13) has the J714s's Secure Enclave and Touch ID sensor, but
apple_sep's T6050 profile admits onlyapple,j714sandapple,k116s, so the driver refuses it with ENODEV. This addsapple,k114sthe way #1649 added the K116s: the match, the profile name and a KUnit case. Three lines.The K114s ADT (read-only, agent-run on the Mac)
Every value the J714s sensor and SEP nodes of #1587 use matches this Mac's ADT. A checker compared 19 facts with a compiled tree that switches those nodes on:
/arm-io/spi2/mesa,sensor-id0x3356 (V3), 8 MHz, chip select 0;0x505108000+0x4000, interrupt 1369, the 24 MHz reference clock;nub-gpio0pin 21, data ready on AP GPIO 138;0x502600000+0x88000and0x502050000, mailbox interrupts 533 to 536;dart-sepat0x500b80000, interrupt 543, window0x10000004000+0xffff0000.Tests
integration/aurora677be395b9with clang 23.1.3 andCONFIG_APPLE_SEP_KUNIT_TEST=y: exit 0, no warnings indrivers/soc/apple.virt, TCG,modprobe apple-sep): 0not okacross 91 suites (640 pass, 1 skip).apple_sep_profilepasses 7/7, includingt8132_selection_is_limited_to_the_m4_airs, which holds the new case.checkpatch --strict: 0 errors. Its only warnings are about theCo-Authored-Bytrailer.On the K114s (agent-run, the owner at the Mac for the touches)
These ran on a K114s kernel (v272-11 base) carrying the same patch, with a tree that enables spi2,
nub_gpio0, the SEP mailbox and power domains, the sensor node and thesepalias.Read-only first (
xart_writes=0 provision_keybag=0):SEP platform profile: T6050/J714s, K116s, K114s, warm bootstrap;ready in 1432 ms: 13 endpoints, key store open, hwrng registered;.glextent with 11 valid records,writes disabled.Then with writes on, the defaults:
xART guard level 1: 9 session records exist, 0 created by Linux, thensks: identity keybag provisioned, and trusted keys work after 2 s. The xART record list was unchanged before and after (11 records: same slot, kind, length and revision, CRCs valid), so no record's metadata changed while the keybag was created, as on the J413. Payload bytes were not compared.aurora-touchid-setupbuiltapple/mesacal-k114s.binandapple/msrk-k114s.binfrom the Mac's own factory data.enroll-completed).verify-matchwith that finger,verify-no-matchwith another. Guard refusals: 0. After enrolment and matching, the 9 pre-Linux session records (8 of kind 4, 1 of kind 3) and the kind-2 record are unchanged in slot, length and revision; one kind-1 shared root record moved from revision 722 to 750 (a later snapshot: revision 759, rewritten to a fresh slot). A wrong finger is also refused in a later boot.Touch ID: restored 1 enrolled identity/identities; enrolment survived reboot, thenverify-matchagain.Not tested
gpio-reserved-ranges. Happy to send them as a follow-up if that's wanted.Edited 2026-11-17: the xART lines now say what the comparison shows (record metadata, not bytes), and the record counts are corrected after an independent check.