Repository navigation
Conversation
Commit 9649e59 ("drm/apple: support retained J613 native26 external displays") made dcp_poweron() flush ext26_blank_work for a native26 external and test dcp_is_retained_external(), so the harness, which compiles dcp_poweron() from the driver, stopped building and both backlight-coldboot runs fail on integration/aurora. Give its apple_dcp the ext26 flag and ext26_blank_work, and stub dcp_is_ext26(), dcp_is_retained_external() and flush_work(), the same stubs aurora-silicon#2124 carries in its integration merge. Assisted-by: LLM
niteria
marked this pull request as ready for review
November 17, 2026 19:25
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backlight-coldboot-tests(both the normal run and--negative-controls) fails to build onintegration/aurorasince 9649e59 ("drm/apple: support retained J613 native26 external displays"):dcp_poweron(), which the harness compiles from the driver, now flushesext26_blank_workand callsdcp_is_ext26()/dcp_is_retained_external(), which the harness's mockapple_dcpdoesn't have.This adds the
ext26flag andext26_blank_workto the mock and stubsdcp_is_ext26(),dcp_is_retained_external()andflush_work(): the same stubs #2124 carries inside its integration merge commit, split out so the suite is green without waiting for that draft.Full
tools/asahi/run-host-tests.pyon this branch (integration/aurora c28f863 + this commit): 425/425 passed, against 423/425 before.🤖 Generated with Claude Code