Skip to content

tools/asahi: backlight-coldboot: stub the retained-external checks - #2169

Closed
niteria wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
niteria:fix/backlight-coldboot-ext26
Closed

niteria wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
niteria:fix/backlight-coldboot-ext26

Conversation

@niteria

@niteria niteria commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

backlight-coldboot-tests (both the normal run and --negative-controls) fails to build on integration/aurora since 9649e59 ("drm/apple: support retained J613 native26 external displays"): dcp_poweron(), which the harness compiles from the driver, now flushes ext26_blank_work and calls dcp_is_ext26() / dcp_is_retained_external(), which the harness's mock apple_dcp doesn't have.

This adds the ext26 flag and ext26_blank_work to the mock and stubs dcp_is_ext26(), dcp_is_retained_external() and flush_work(): the same stubs #2124 carries inside its integration merge commit, split out so the suite is green without waiting for that draft.

Full tools/asahi/run-host-tests.py on this branch (integration/aurora c28f863 + this commit): 425/425 passed, against 423/425 before.

🤖 Generated with Claude Code

Commit 9649e59 ("drm/apple: support retained J613 native26 external
displays") made dcp_poweron() flush ext26_blank_work for a native26
external and test dcp_is_retained_external(), so the harness, which
compiles dcp_poweron() from the driver, stopped building and both
backlight-coldboot runs fail on integration/aurora.

Give its apple_dcp the ext26 flag and ext26_blank_work, and stub
dcp_is_ext26(), dcp_is_retained_external() and flush_work(), the same
stubs aurora-silicon#2124 carries in its integration merge.

Assisted-by: LLM
@niteria
niteria marked this pull request as ready for review November 17, 2026 19:25
@niteria

niteria commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #2168, which fixes the same fixture (merged as 432f175); backlight-coldboot passes on integration/aurora with it, negative controls included.

@niteria niteria closed this Nov 17, 2026
@niteria
niteria deleted the fix/backlight-coldboot-ext26 branch November 17, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant