Repository navigation
arm64: dts: apple: t6041-j616c: system power state for the port controllers - #2174
Draft
AxxzyWasTaken wants to merge 1 commit into
Draft
AxxzyWasTaken wants to merge 1 commit into
AxxzyWasTaken wants to merge 1 commit into
Conversation
…ollers macOS tells the USB-C port controllers the system power state (SSPS), S3 before a sleep and S0 after it. The tipd driver does the same around a firmware-driven suspend for a controller with apple,sleep-ssps, as the J700, J714s, J716c and J813/J815 have. Give it to the J616c's four SN201202x controllers: hpm0, hpm1, hpm2 and MagSafe's hpm5. Assisted-by: LLM Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1664 (draft until it lands). It doesn't need #1664's commits to apply.
macOS tells the USB-C port controllers the system power state (SSPS): S3 before a sleep and S0 after it. For a controller with
apple,sleep-ssps, the tipd driver does the same around a firmware-driven suspend. The J700, J714s, J716c and J813/J815 have the property; the J616c's four SN201202x controllers don't. This adds it to hpm0, hpm1, hpm2 and MagSafe's hpm5.The property only matters for a firmware-driven suspend, which T6041 gets from #1664. It has nothing to do with #1889's idle sleep, which is runtime PM. On the J616c, the driver uses the plain SSPS path (no
tipd_sleep_ssps_rules()): a failed S3 is a warning, not a refused sleep.Testing
apple,sleep-sspson the fourusb-pdnodes. No new dtc warnings withW=1. I couldn't rundtbs_check(no dtschema here); the sn201202x binding already has the property.