Skip to content

arm64: dts: apple: t6041-j616c: system power state for the port controllers - #2174

Draft
AxxzyWasTaken wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
AxxzyWasTaken:pr/j616c-usbpd-sleep-ssps
Draft

AxxzyWasTaken wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
AxxzyWasTaken:pr/j616c-usbpd-sleep-ssps

Conversation

@AxxzyWasTaken

Copy link
Copy Markdown
Contributor

Depends on #1664 (draft until it lands). It doesn't need #1664's commits to apply.

macOS tells the USB-C port controllers the system power state (SSPS): S3 before a sleep and S0 after it. For a controller with apple,sleep-ssps, the tipd driver does the same around a firmware-driven suspend. The J700, J714s, J716c and J813/J815 have the property; the J616c's four SN201202x controllers don't. This adds it to hpm0, hpm1, hpm2 and MagSafe's hpm5.

The property only matters for a firmware-driven suspend, which T6041 gets from #1664. It has nothing to do with #1889's idle sleep, which is runtime PM. On the J616c, the driver uses the plain SSPS path (no tipd_sleep_ssps_rules()): a failed S3 is a warning, not a refused sleep.

Testing

  • My J616C (32-core M4 Max) has booted DTBs with this property on these four nodes since 9 Nov, with soc: apple: suspend-to-RAM on the M4 Max (T6041, J616c) #1664's suspend-to-RAM. I haven't confirmed that the controllers take S3: the driver logs success only at debug level, and in my sleep tests the log was saved before that point.
  • This branch: the J616c DTB builds, and the decompiled DTB has apple,sleep-ssps on the four usb-pd nodes. No new dtc warnings with W=1. I couldn't run dtbs_check (no dtschema here); the sn201202x binding already has the property.
  • The J614c shares these nodes but is left unchanged: I couldn't test it.

…ollers

macOS tells the USB-C port controllers the system power state (SSPS),
S3 before a sleep and S0 after it. The tipd driver does the same around
a firmware-driven suspend for a controller with apple,sleep-ssps, as the
J700, J714s, J716c and J813/J815 have. Give it to the J616c's four
SN201202x controllers: hpm0, hpm1, hpm2 and MagSafe's hpm5.

Assisted-by: LLM
Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant