Repository navigation
Conversation
… build The paired mode set (a mode too wide for one engine, run on two) sends its IOMFB calls through dcp_peer_video_call_stream(), naming them by their 27.0 IDs. Firmware 27.2 renumbered the IOMobileFramebufferAP methods, and an ID the firmware does not know panics it: on a 27.2 stub the paired prepare's set_display_device went out as A411 and crashed both engines. Translate each call's ID through the engine's build-selected table (iomfb_v27_tag()): a method the tables name takes this build's ID, and on 27.2 another A4xx ID (A449) moves up by 50 with the rest of IOMobileFramebufferAP. Other IDs, and every ID on 27.0, are sent as before. Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
Besides the paired calls, the firmware 27 paths name some calls by their 27.0 IDs: the primary's paired mode set (A413) and power step (A484), the paired background swap (A408), the sleep's power and A500 steps, the display stage calls and A442. On 27.2, which renumbered IOMobileFramebufferAP, several of those IDs are other methods: the paired mode's power step ran one and failed, and the second engine of a 4K240 mode never started. Translate each of them through the engine's build-selected table (iomfb_v27_tag()). The J714s's A407 swap keeps its ID, which only its 27.0 table names, and its diagnostic now refuses a pair whose engines take different swap forms. 27.0 sends what it sent. Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
The J716c's display processors take part in a deep sleep through the
firmware 27 endpoint transport, which was admitted on a 27.0
compatibility build only. On a 27.2 stub no processor registered for the
sleep, and every deep sleep was refused ("display 0: no provider").
Admit 27.2.0 as well. Its endpoint transport is the 27.0 one, and the
IOMFB calls the sleep makes are sent with the build's IDs.
Developed with Claude Code.
Signed-off-by: Erik Bourget <erik@ebourget.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the M5 Max (J716c) drive external displays, including the paired 4K240 mode, and take part in a deep sleep on the macOS 27.2 (26B123) firmware.
Firmware 27.2 renumbered the IOMobileFramebufferAP methods (A4xx and A500 up by 50); the build-selected method tables already carry that for the table-driven calls. Three things still assumed 27.0 on the J716c's display engines. Together with the loader change in aura #282 (which gives the external engines the stub's
apple,firmware-compat), this makes them work on a 27.2 stub. 27.0 sends exactly what it sent.Change
dcp_peer_video_call_stream()named 27.0 IDs; the first one (set_display_device, A411) panicked both engines on 27.2.iomfb_v27_tag()translates an ID through the engine's table, with +50 for other A4xx IDs on 27.2.The paired DSC hand-off calls (A360..A373) and A375 are sent unchanged; their 27.2 numbering is not known, and the paired 4K240 mode runs with them.
Testing
On a J716c (M5 Max, 128 GB) with an MSI MPG 322U X24 pair on a Thunderbolt 5 dock, one kernel (this branch with #1956, #1957, #2162, #2177 and #2185 on
integration/aurora59b02d5) and auramainplus #280, #281 and #282:🤖 Generated with Claude Code