Repository navigation
media: apple: avd: VP9: one segmentation map per stream, shared by the banks - #2195
Open
m0d16l14n1 wants to merge 1 commit into
Open
m0d16l14n1 wants to merge 1 commit into
m0d16l14n1 wants to merge 1 commit into
Conversation
…e banks The segmentation map is state that runs from frame to frame: a frame with temporal map prediction, or one that keeps the map without updating it, reads the map the frame before it left. With the queued transport (two banks, alternating) each bank had its own seg buffer, so a frame read the map of the frame before last. Every stream with segmentation then decoded wrong from its first non-key frame on. Keep one seg buffer per stream and point both banks at it. Tested on J815 (MacBook Air 15" M5), frame-by-frame MD5 against libavcodec, full decode and a seek into the stream: - before: libvpx aq-mode 2 (complexity) and 3 (cyclic refresh) at 720p and 1080p, and a 360p screen-content clip, wrong from frame 1-3; - after: all of them bit-exact, with the rest of a 67-stream H.264, HEVC, VP9 and AV1 set (59 of 59 PASS; the other 8 are 10-bit and interlaced streams the driver does not expose). The single-bank transport also decoded them right, which pointed at the bank swap. Signed-off-by: Nick <nekreshen@yandex.ru> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nick <nekreshen@yandex.ru>
Contributor
|
Same bug and same fix on a J813 (MacBook Air 13" M5). The AVD runs the open-queue transport here ( Test streams, made with libvpx-vp9 from
"Without" is my kernel on #2135's merged head 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VP9 segmentation map carries over from frame to frame: a frame with temporal map prediction, or one that keeps the map without updating it, reads the map the frame before it left. With the queued transport the two banks alternate, and each had its own seg buffer, so a frame read the map of the frame before last. Every stream with segmentation decoded wrong from its first non-key frame.
Change: one seg buffer per stream, used by both banks.
Tested on J815 (MacBook Air 15" M5), with frame-by-frame MD5 against libavcodec, full decode plus a seek:
checkpatch --strictis clean, and the change builds withW=1onintegration/aurora.Part of the J815 bring-up; board results are summarised in #135.
🤖 Generated with Claude Code