Repository navigation
cpufreq: apple-soc: offer no boost control without turbo-mode OPPs - #2199
scottjones wants to merge 1 commit into
Conversation
Since commit f677f7c ("cpufreq: apple-soc: start with boost enabled") the driver turns boost on when it registers. On SoCs whose device tree marks no OPP as turbo-mode, such as the M3 (T8122) and the MacBook Neo, no policy supports boost. The driver still sets .set_boost, so the core creates the global boost file anyway, and enabling it fails: cpufreq: cpufreq_boost_trigger_state: Cannot enable BOOST cpufreq: store_boost: Cannot enable BOOST! power-profiles-daemon writes that file when it applies a profile, so on these Macs it fails, and power-saver no longer lowers the CPU limit. Leave .set_boost unset when the tree has no turbo-mode OPP, so no boost file appears there. SoCs with turbo-mode OPPs keep boost control as before. Tested on an M3 MacBook Air (J613) and a MacBook Neo: no boost errors, and power-saver caps the P-cores (J613: 4056 to 2424 MHz). On a 16" M4 Pro (J616s) the boost file is still there: power-saver runs the P-cores at 4104 MHz and performance at 4512 MHz. Assisted-by: Claude:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Scott Jones <scottajones@gmail.com>
|
Same on the M5 Air (J813, T8142). Its device tree has no turbo-mode OPPs either. Without this commit, on #2135's merged head With this commit on the same base, together with #1906 and
Two real deep sleeps on that boot came back clean. 🤖 Generated with Claude Code |
|
Claude Code wrote this up from my tests. Same on the J615 (15-inch M3 Air). Users notice it in the performance profile. Without this commit power-profiles-daemon stops at the boost write and never sets its governor, so the CPUs stay on schedutil whichever profile is picked. On this Mac that made Chromium scroll badly enough that 7.3 looked like a regression against 7.2. Both kernels are integration/aurora With it there's no
The scroll test is Chromium 156.0.8078.79 full screen on the built-in panel (2880x1864 at scale 1.6), scrolling a 21000 px page with 101 images at 2000 px/s for 20 s. Four runs per kernel, medians, performance profile selected each time.
Balanced with this commit also runs schedutil. On the same kernel it gave 4.6 % dropped frames (1.8 to 10.6 % per run) at 83 ms p50. |
Since f677f7c ("cpufreq: apple-soc: start with boost enabled"), Macs whose device tree has no turbo-mode OPPs, such as the M3 Air and the MacBook Neo, log
Cannot enable BOOSTwhen power-profiles-daemon applies a profile, and power-saver no longer lowers the CPU limit. This leaves.set_boostunset on those SoCs, so no boost file appears. SoCs with turbo-mode OPPs keep boost control, and keep f677f7c's boost-on default.Tested with this commit on top of integration/aurora 0abc2f3, together with aura main and Mesa aurora-wip:
🤖 Generated with Claude Code