Skip to content

cpufreq: apple-soc: offer no boost control without turbo-mode OPPs - #2199

Open
scottjones wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
scottjones:upstream/cpufreq-boost-turbo-only
Open

scottjones wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
scottjones:upstream/cpufreq-boost-turbo-only

Conversation

@scottjones

Copy link
Copy Markdown
Contributor

Since f677f7c ("cpufreq: apple-soc: start with boost enabled"), Macs whose device tree has no turbo-mode OPPs, such as the M3 Air and the MacBook Neo, log Cannot enable BOOST when power-profiles-daemon applies a profile, and power-saver no longer lowers the CPU limit. This leaves .set_boost unset on those SoCs, so no boost file appears. SoCs with turbo-mode OPPs keep boost control, and keep f677f7c's boost-on default.

Tested with this commit on top of integration/aurora 0abc2f3, together with aura main and Mesa aurora-wip:

  • M3 Air (J613), lab job j1118-185603-b25d: no BOOST lines, power-saver caps the P-cores at 2424 MHz (from 4056).
  • MacBook Neo, lab job j1118-185622-b473: no BOOST lines, power-saver caps.
  • 16" M4 Pro (J616s), by hand: boost file present, 4104 MHz on power-saver, 4512 MHz on performance, no errors.

🤖 Generated with Claude Code

Since commit f677f7c ("cpufreq: apple-soc: start with boost
enabled") the driver turns boost on when it registers. On SoCs whose
device tree marks no OPP as turbo-mode, such as the M3 (T8122) and the
MacBook Neo, no policy supports boost. The driver still sets
.set_boost, so the core creates the global boost file anyway, and
enabling it fails:

  cpufreq: cpufreq_boost_trigger_state: Cannot enable BOOST
  cpufreq: store_boost: Cannot enable BOOST!

power-profiles-daemon writes that file when it applies a profile, so on
these Macs it fails, and power-saver no longer lowers the CPU limit.

Leave .set_boost unset when the tree has no turbo-mode OPP, so no boost
file appears there. SoCs with turbo-mode OPPs keep boost control as
before.

Tested on an M3 MacBook Air (J613) and a MacBook Neo: no boost errors,
and power-saver caps the P-cores (J613: 4056 to 2424 MHz). On a 16"
M4 Pro (J616s) the boost file is still there: power-saver runs the
P-cores at 4104 MHz and performance at 4512 MHz.

Assisted-by: Claude:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Scott Jones <scottajones@gmail.com>
@gig3m

gig3m commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Same on the M5 Air (J813, T8142). Its device tree has no turbo-mode OPPs either.

Without this commit, on #2135's merged head 408e27268fd6, power-profiles-daemon logged this at every start:

cpufreq: cpufreq_boost_trigger_state: Cannot enable BOOST
cpufreq: store_boost: Cannot enable BOOST!
power-profiles-daemon: Failed to activate initial profile: Failed to activate CPU driver 'cpufreq': Error writing '/sys/devices/system/cpu/cpufreq/boost': Invalid argument

With this commit on the same base, together with #1906 and CONFIG_ACPI=y:

  • there's no global boost file and no BOOST lines;
  • power-profiles-daemon starts without the error;
  • both clusters keep their full table (P 4464 MHz, E 2964 MHz).

Two real deep sleeps on that boot came back clean.

🤖 Generated with Claude Code

@freber

freber commented Nov 18, 2026

Copy link
Copy Markdown

Claude Code wrote this up from my tests.

Same on the J615 (15-inch M3 Air). Users notice it in the performance profile. Without this commit power-profiles-daemon stops at the boost write and never sets its governor, so the CPUs stay on schedutil whichever profile is picked. On this Mac that made Chromium scroll badly enough that 7.3 looked like a regression against 7.2.

Both kernels are integration/aurora 59b02d5ef with #2145 to #2157, #2090, #1985 and a port of omacom/linux-aurora#410, #491 and #500 on top of #2147. The only difference is this commit.

With it there's no boost file, no BOOST lines and no daemon errors across profile switches.

Profile Governor P-core / E-core limit
power-saver schedutil 2424 / 1476 MHz
balanced schedutil 4056 / 2748 MHz
performance performance 4056 / 2748 MHz

The scroll test is Chromium 156.0.8078.79 full screen on the built-in panel (2880x1864 at scale 1.6), scrolling a 21000 px page with 101 images at 2000 px/s for 20 s. Four runs per kernel, medians, performance profile selected each time.

Without this commit With it 7.2 (omacom aurora16 with my J615 patches)
Dropped frames 8.2 % 0 % 0 %
Frame latency p50 83 ms 34 ms 34 ms
Chromium GPU process CPU per frame 7.5 ms 0.9 ms 1.2 ms
Renderer CPU per frame 4.1 ms 0.5 ms 0.5 ms

Balanced with this commit also runs schedutil. On the same kernel it gave 4.6 % dropped frames (1.8 to 10.6 % per run) at 83 ms p50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants