Repository navigation
media: apple: avd: T8142: 15 instruction FIFOs and the Hibiscus VP pool - #2219
Merged
DjDeveloperr merged 1 commit intoNov 19, 2026
Conversation
The M5's decoder is a Hibiscus part: macOS's AppleAVD moves T8142 to its Hibiscus classes when the low half of ctrl+0 reads 0x20, which the MacBook Air 15" M5 (J815) does (0x40020). CAvdApCommHibiscus asks for 15 instruction FIFOs, and the v5 tier 2 avd-fw build T8142 already runs reports 15 FIFOs and a 4/4/1/3 VP pool, so use them instead of T8140's 7 FIFOs and the one-or-two VPs per codec. The first VP of each codec stays where it was (0/4/8/9), now as the default contiguous layout. Tested on the J815 on two boots: Fluster HEVC 143/147, AV1 235/242, VP9 177/303 and AVC unchanged from 7 FIFOs (the same vectors fail either way; VP9 4 better), and 59 decode checks of a real-world set (H.264, HEVC, VP9, AV1 up to 4K; whole streams and seeks), each frame equal to software decoding. Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
DjDeveloperr
merged commit Nov 19, 2026
df73b90
into
aurora-silicon:integration/aurora
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The M5's decoder is a Hibiscus part, not T8140's Tansy:
CAvdApCommHibiscusasks for 15 instruction FIFOs (Tansy: 7).Change: T8142 uses 15 FIFOs and VP counts 4/4/1/3 (HEVC/H.264/VP9/AV1). Each codec's first VP stays where it was (0/4/8/9), now as the default contiguous layout, so
vp_slot_basegoes away.Tested on J815 (MacBook Air 15" M5), two boots with 15 FIFOs against two earlier boots with 7:
On one of the two boots, three AV1 vectors failed once (quantizer-44, size-202x196, svc-L1T2). They passed on the other boot and on the 7-FIFO boots, and they came right after a deliberately bad H.264 High 10 run that reset the decoder. They will be re-run on a fresh boot; I'll update here.
checkpatch --strictclean.W=1onintegration/aurora0abc2f3.Part of the J815 bring-up; board results are summarised in discussion #135.
🤖 Generated with Claude Code