Repository navigation
arm64: dts: apple: t8132-j713-j715: give the J715 the J713's sleep, enclave and display power wiring - #2245
Draft
RyanTheTide wants to merge 2 commits into
Draft
arm64: dts: apple: t8132-j713-j715: give the J715 the J713's sleep, enclave and display power wiring#2245RyanTheTide wants to merge 2 commits into
RyanTheTide wants to merge 2 commits into
Conversation
Every T8132 has the ANE; the DT enabled it, with its three DARTs, on the J713 only, the board it was first run on (#1952). The node's resources and power domains are the SoC's, and the driver binds only when the loader hands off the firmware preload (aura#260 does so for any apple,t8132-ane node), so enable it in the SoC file and drop the J713 copy. The J713's DT is unchanged. Not tested on the J604, J715, J623/J624 or J773g (desk audit, lane SPEC-M3M4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nclave and display power wiring The J715 (MacBook Air 15", M4) is the J713 board with a larger panel and six amps; its ADT matches the J713's apart from the radio island and the ATC PHY trims (t8132-j715.dts). Yet the deep-sleep controller, both cluster power gates, the SEP (which Touch ID's match path needs, and the J715 DT already enables the Mesa sensor), the DCP and external-DCP power gating, the USB4/DCP DART clock-protection slices, the radio port's CLKREQ and the ACIO PHY links sat in t8132-j713.dts only, with "tested on this machine only" as the reason. Move them unchanged into the shared J713/J715 file. The J713 DT compiles to the same tree (dtc -s output identical before and after). Not tested on a J715: needs a J715 boot, Touch ID enroll, and an s2r cycle with and without a dock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2244 (same lines of
t8132-j713.dts); merge that first.Problem. The J715 (MacBook Air 15", M4) is the J713 board with a bigger panel and more amps, but its DT lacked the J713's deep-sleep controller, both cluster power gates, the SEP (which Touch ID needs; the J715 already enables the fingerprint sensor), DCP and external-DCP power gating, the DCP/USB4 DART clock-protection slices, the radio port CLKREQ and the ACIO PHY links. All of that sat in
t8132-j713.dtswith "tested on this machine only" as the reason.Change. Move those blocks unchanged into the shared
t8132-j713-j715.dtsi. Board-specific parts (radio island, ATC PHY trims, panel, amps) stay in the board files.Testing. cpp + dtc on all six T8132 boards: same warning counts. J713's sorted decompile is byte-identical before and after.
Still to run. On a J715: boot, Touch ID enroll and match, s2r with and without a dock.
Assisted-by: LLM (Claude:Opus 5.5)