Repository navigation
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Thanks. Applying the PMGR policy whatever the firmware is the right direction: the policy describes the SoC's power manager, not a firmware release. One change. With this PR the policy is supplied on every firmware. A power state that it fails to mark should then also fail closed on every firmware, not only on the Airs and 26.6.2. Could you key the guard on the handoff being built instead, e.g. Rows: your J773g boots on the 27.2 stub cover that machine. Still needed:
|
The platform handoff that applies the M4 PMGR ownership policy runs only where apple_t8132_firmware_path() is true: the Airs, or OS firmware 26.6.2. On any other firmware the T8132 power states are registered as the SoC tree describes them and Linux switches domains the firmware owns. A J773g on the macOS 27.2 stub resets two to four seconds into every boot that way. The policy describes the SoC's power manager, so select it by the hardware it is written for: run the handoff on every T8132 tree. It walks the apple,t8132-pmgr nodes and marks each power state with the status and ownership of the embedded policy tree, whatever the OS firmware. No version string is compared for it. pmgr-pwrstate follows: with the handoff built, a T8132 power state it did not mark fails with "missing M4 power-domain policy" on any firmware, not only on the Airs and 26.6.2. That includes the case where the handoff cannot resolve a live PMGR node in its policy tree and drops the whole changeset: every T8132 power state that has no status of its own in the tree then fails closed; a state the tree marks itself (all of them on the complete J713 tree) is registered or left out as the tree says. A kernel built without the handoff used to fail closed on the Airs' loader tree and on 26.6.2; it now registers those states. Within the handoff apple_t8132_air() and the policy tree's apple,policy-machine entries stay: they choose between the legacy J713 loader tree's rules and the others', not whether the policy runs. Every T8132 Mac off 26.6.2 now gets the policy. Only the J773g has been run there; no J604, J623 or J624 off 26.6.2 has. Assisted-by: LLM Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
f80b351 to
25b5b73
Compare
|
Thanks, the amended commit keys the fail-closed guard on The rows from before are still open: one other T8132 Mac (J604, J623, J624, J713 or J715) on non-26.6.2 firmware without the bring-up parameters (up 10 minutes or more, the |
A J773g on the macOS 27.2 stub (26B123) resets two to four seconds into every boot: the platform handoff that applies the M4 PMGR ownership policy ran only on the Airs or on OS firmware 26.6.2, so elsewhere Linux registered and switched power states the firmware owns.
Change.
pmgr-pwrstate.c: the fail-closed guard is keyed on the handoff being built (IS_ENABLED(CONFIG_APPLE_T8132_PLATFORM_HANDOFF)) instead of the firmware test, as asked in review. With the handoff built, a T8132 power state it did not mark fails withmissing M4 power-domain policyon any firmware. With it not built, states are registered as the tree describes them.t8132.hcomment and the Kconfig help say this.Consequence of the guard, stated plainly. If the handoff cannot resolve a live
apple,t8132-pmgrnode in its embedded policy tree it drops the whole changeset, and then every T8132 power state that has no status of its own in the tree fails closed, on every firmware; a state the tree marks itself (all of them on the complete J713 tree) is registered or left out as the tree says. Before, that was the outcome on the Airs and 26.6.2 only; off 26.6.2 the states were registered unmarked. A machine that booted that way off 26.6.2 would now not register those domains. This is the behaviour the review asked for. A kernel built without the handoff used to fail closed on the Airs' loader tree and on 26.6.2; it now registers those states.What "no board or version is compared" covers. Selection only. Inside the handoff
apple_t8132_air()still chooses the legacy J713 loader tree's rule against the other trees', and the policy tree'sapple,policy-machine = "apple,j713"entries keep nine J713-only states from other boards. Both are data about board wiring, unchanged.Blast radius. Every T8132 Mac off 26.6.2 now gets the policy. Only the J773g has been run there.
Rows
J773g (Mac16,10, 16 GB, AQC113), macOS 27.2 stub (26B123), one boot each unless noted:
supplied 0 platform nodes, 137 PMGR policy properties,keeps 1 of 2 power domains, no reset; plain line:clk: Disabling unused clocks,PM: genpd: Disabling unused power domains, SSH still answering at 120.8 ssupplied 0 platform nodes, 137 PMGR policy properties,keeps 1 of 2 power domains; 0missing M4 power-domain policylines; no reset;clk: Disabling unused clocks,PM: genpd: Disabling unused power domains; 64 MiB direct NVMe write at about 625 s; no WARNING/BUG/Oops, no NVMe errorWithout the change every kernel resets on that stub.
Rows we cannot provide.
Host: apple-dcp suite 88/88 on this head (base 88/88). Builds with W=1 on the touched objects. checkpatch
--strict: clean. Not run:dt_binding_check(no binding changes), KUnit.Assisted-by: LLM