Repository navigation
arm64: dts: apple: t8142: share the AOP, ambient light and lid angle with every M5 - #2329
Draft
RyanTheTide wants to merge 1 commit into
Draft
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
The AOP core, its mailboxes and dart-aop were described in the J813/J815
sound file (t8142-j813-audio.dtsi) and the ambient light and lid angle
services in each board file, so the MacBook Pro J704 had none of them.
The J704, J813 and J815 ADTs agree on /arm-io/aop (reg, interrupts
490-493, iop,ascwrap-v6), aop-exclave-mailbox (0x3d067c000, interrupts
497/494), dart-aop (0x390fc0000, interrupt 528) and every
/arm-io/aop/iop-aop-nub service, als included, and all three carry the
lid angle sensor's i2c1 "mogul-las" authentication chip.
Move aop_mbox, aop_setup_mbox, the aop node and its als and las
services to t8142-peripherals.dtsi and enable aop_dart in t8142.dtsi,
so every T8142 board gets them. The AOP core runs without its audio
child (J815 runs so today), and aop registers a service child only when
its firmware announces the service. t8142-j813-audio.dtsi keeps only
&aop { aop_audio }. dart-aop and aop have no ADT power-gates: AOP_DART
sits in the AOP's own always-on power tree, so the DART names no power
domain (the AOP DARTs are exempt from the DART power-domain rule).
J813 and J815 compile to the same tree apart from node order, phandle
numbers and aop_dart losing its now redundant status = "okay". J704
gains the AOP, both mailboxes, dart-aop, als and las.
The moved nodes are Thomas Glanzmann's (AOP, mailboxes, dart-aop:
"t8142-j813: Sound through the AOP"), Diljit Singh's and Nick's (als),
and Nick's (las).
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Contributor
|
J813 row. The kernel is #2325's head with #1899/#1900 and
Not run: the covered/lamp ALS comparison and the lid at 30/90/120 degrees. The first needs the calibration file, and both need someone at the machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MacBook Pro 14-inch M5 (J704) has no AOP, so no ambient light sensor (True Tone) and no lid angle. The AOP core, its two mailboxes and dart-aop were described in the J813/J815 sound file, and the
als/lasservices in each Air board file. The J704, J813 and J815 ADTs agree on all of them:/arm-io/aop: reg, interrupts 490-493.aop-exclave-mailbox: interrupts 497/494.dart-aop: interrupt 528./arm-io/aop/iop-aop-nubservice,alsincluded.mogul-laschip.Change
aop_mbox,aop_setup_mboxandaopwith itsalsandlasservices intot8142-peripherals.dtsi, on by default.aop_dartint8142.dtsi.t8142-j813-audio.dtsikeeps only&aop { aop_audio }and the rest of the sound description.als/lasblocks.The AOP runs without its audio child (the J815 does so today), and the driver creates a service device only when the firmware announces that service.
Testing
cpp + dtc before and after:
aop_dartlosing its now redundantstatus = "okay".alsandlas.dt-validate -mreports nothing new on any of the three boards.Still to run
dmesg | grep -i aop: the AOP boots and lists its services, with no DART fault or SError./sys/bus/iio/devices/*/in_illuminance_rawchanges between covered and under a lamp.Details
pmgr_aopstays in the sound file: it only holds audio domains.t8142-j815.dts: drop thealsblock there, keep accel/gyro.apple/aop-als-cal.bincomes from the installer.traces/kernel/20261119-dtfill-m5m6/(patches/t8142-aop with the per-board diffs).Assisted-by: LLM (Claude:Opus 5.5)