Repository navigation
arm64: dts: apple: t8152: CPU idle driver on every M6 - #2333
Draft
RyanTheTide wants to merge 2 commits into
Draft
RyanTheTide wants to merge 2 commits into
RyanTheTide wants to merge 2 commits into
Conversation
As on T8140, the OS cannot request core power-down on T8152 (M6) and WFI is the only idle state. Allow "apple,t8152-cpuidle" with the T8140 compatible as its fallback, which the driver already matches. Signed-off-by: LiamRay11 <228416644+LiamRay11@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The J873g (Mac mini, M6) has no cpuidle node, so cpuidle-apple never binds there: the CPUs idle through the default WFI without a cpuidle driver, and s2idle cannot freeze the tick or suspend timekeeping. The J804 board file in #2107 adds the node for that board only. The cores and their idle behaviour are the SoC's: as on T8140, the OS cannot request core power-down and WFI is the only state, which the T8140 profile of the driver already handles (CYC_OVRD is left alone on anything newer than M3). Put the node in t8152-peripherals.dtsi, which both the J873g tree and t8152.dtsi (J804, J833ct) include. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This was referenced Nov 19, 2026
Open
Contributor
|
J873g row. Kernel: #2178's head + this PR's two commits (
No cpuidle warnings in dmesg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Mac mini M6 (J873g) has no cpuidle node, so cpuidle-apple never binds. The CPUs idle through the default WFI without a cpuidle driver, and s2idle cannot freeze the tick or suspend timekeeping. #2107 adds the node to the J804 board file only.
Change
Add
cpuidle { compatible = "apple,t8152-cpuidle", "apple,t8140-cpuidle"; }tot8152-peripherals.dtsi. Both the J873g tree andt8152.dtsi(J804, J833ct) include that file. As on T8140, the OS cannot request core power-down and WFI is the only state. The driver's T8140 profile already handles that: it does not touch CYC_OVRD on anything newer than M3.The binding change is LiamRay11's commit from #2107, carried unchanged (same patch-id), so this can land before or after #2107. If both land, the J804 board file's own
cpuidlenode merges into this one.Testing
cpp + dtc before and after: J873g, J804 and J833ct each gain only
/cpuidle.dt-validate -mwith this branch's bindings reports nothing new on any of them (J873g keeps its 31 existing warnings).Still to run
cat /sys/devices/system/cpu/cpuidle/current_drivershowscpuidle-apple./sys/devices/system/cpu/cpu*/cpuidle/state*/usageclimbs.sensors(PSTR) before and after, if the SMC exposes it.Details
apple,t8140-cpuidlefallback (drivers/cpuidle/cpuidle-apple.cmatch table). With no T8152 entry in its CYC_OVRD machine list, both of its states are WFI.traces/kernel/20261119-dtfill-m5m6/(dts-t8152idle, valm-t8152idle-*).Assisted-by: LLM (Claude:Opus 5.5)