Repository navigation
arm64: dts: apple: t8132-laptop: describe the MagSafe 3 PD controller - #2395
Draft
RyanTheTide wants to merge 1 commit into
Draft
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
The M4 laptops (J604, J713, J715) have a third SN201202x on nub-spmi-a0
for the MagSafe 3 port (hpm5). It is not described, so there is no
Type-C port and no tps6598x power supply for MagSafe; only the SMC sees
the charger.
Each board's ADT gives the same values: SID 8 on nub-spmi-a0, event,
sleep and wake interrupts 63, 69 and 71 (the order of hpm0's 11, 17,
19), port-type 0x11, and features-supported <3> ("Power In" only). Add
it once to t8132-laptop.dtsi, which all three include, with the T8132
compatible (selection is polled, event/sleep/wake use interrupts), no
connector node (no USB data path) and apple,no-liquid-detection, as the
J714s and the J815 MagSafe nodes do. The J604's comment that said hpm5
is not wired now points at the shared node.
The desktops (J623, J624, J773g) do not include t8132-laptop.dtsi and
build to identical DTBs.
The node follows the J815 MagSafe node by Nick (m0d16l14n1) and the
J714s one.
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The M4 MacBook Air 13/15 (J713, J715) and the MacBook Pro 14 M4 (J604) have no node for the MagSafe 3 port's PD controller (hpm5). Charging works through the SMC, but there is no Type-C port and no tps6598x power supply for MagSafe. The J604 file said hpm5 "is not wired".
Change
t8132-laptop.dtsi(included by J604, J713 and J715): addhpm5: usb-pd@8onnub_spmi_a0, compatibleapple,t8132-sn201202x,apple,sn201202x, with the event, sleep and wake interrupts,apple,no-liquid-detectionand no connector node. Same shape as the J714s hpm5 and the J815 one in arm64: dts: apple: t8142-j815: MagSafe 3 PD controller #1907, with the T8132 interrupt layout of hpm0/hpm1.t8132-j604.dts: the stale comment now points at the shared node.wakeup-sourcefor now (hpm0/hpm1 have it); MagSafe plug wake can be added once the port is seen working.The tipd SPMI driver takes a node without a connector (the role switch and mux lookups get NULL, as on J714s). No board list in the driver excludes T8132 for this node. The sleep lists in
core.c(tipd_sleep_ssps_rules) andspmi.c(sn201202x_sleep_board) do not name T8132 boards, the same as for hpm0/hpm1.Testing
apple,sn201202x.yaml): 0 new messages on J604, J713, J715.Still to run
/sys/class/typec/portNappears and the hpm5tps6598x-source-psy-*power supply showsonline=1; unplug ->online=0;dmesg | grep -i tps6598xshows no probe errors forusb-pd@8.No loader change is needed.
Per-board values and DTB diffs
Values come from each board's ADT (27.x), and also match the public live ADTs for J713 and J604.
DTB diff (identical on J604, J713, J715):
Assisted-by: LLM (Claude:Opus 5.5)