Repository navigation
drm/apple, soc: apple: remove the T6030 manual external-display path (-1781) - #2432
Draft
RyanTheTide wants to merge 1 commit into
Draft
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
The T6030 display gate has two modes. The default, native, runs the external display coprocessor through the 14.7 IOMFB service in the main DRM device. The "manual" mode, which display-gate.c calls "the earlier diagnostic path", only runs with apple_t6030_display.dcpext_manual=1: the gate then marks the scanout node apple,t6030-scanout-verified and dcpext_scanout/dcpext_drm present a test pattern and register a separate DRM device. Native mode replaced it, and nothing we ship sets the parameter (kernel configs, distro and platform packages, aura, lab kits). Remove the early_param and the manual branch of the gate, the dcpext_scanout and dcpext_drm files (the dcpext_pageflip parameter and the dcpext_pattern, dcpext_desktop, dcpext_status and dcpext_present sysfs files), their hooks in dcp.c, dcp-fabric.c, iomfb_v14_7.c and ibootep.c, the ibootep pattern helpers only they used, and two host test stubs for the removed functions. Every removed hook keyed on dcp->dcpext_scanout, which only the manual mode could set, so the native path is unchanged. The manual path was written by Chris Kearney (98d767e, 718c6a3, e6c1062 and later). Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The T6030 (M3 Pro/Max) display gate still carries its old "manual" external-display path next to the native one that replaced it. With
apple_t6030_display.dcpext_manual=1the gate marks the scanout node verified, and dcpext_scanout/dcpext_drm present a test pattern and register a separate DRM device.display-gate.citself calls this "the earlier diagnostic path". Nothing we ship sets the parameter, so about 1,800 lines only run on a command line nobody uses.Change
dcpext_manualearly_param and the manual branch. The comment block now describes the remaining outcomes, native or refused.dcpext_pageflipparameter and thedcpext_pattern,dcpext_desktop,dcpext_statusanddcpext_presentsysfs files.Net -1,781 lines. Every removed hook keyed on
dcp->dcpext_scanout, which only the manual mode could set, so the default native path does not change. The manual path was Chris Kearney's bring-up work (98d767e, 718c6a3, e6c1062).Kept on purpose: the explicit-start path for a dcpext that isn't native-shaped (
iomfb_v14_7_external_start, sysfsdcpext_start). A real boot can still reach it if the native check fails, so it isn't provably dead.Testing
make Image modules dtbsRC=0, 5,909 modules, modpost reports no undefined symbols, and the only warnings are ones the baseline already had in untouched files.make W=1 drivers/gpu/drm/apple/ drivers/soc/apple/with the fleet config, before and after: RC=0, same warning set..modinfoof appledrm.o: onlydcpext_pageflip(parm and parmtype) disappears.dcpext_manual,dcpext_pageflipand the sysfs names: nothing in the kernel tree, fedora/alarm/nixos/aurora-platform, aura or the lab kits.Still to run
Assisted-by: LLM (Claude:Opus 5.5)