Skip to content

drm/apple: T6050: freeze the firmware 27 sleep sequence at its defaults (-86) - #2465

Draft
RyanTheTide wants to merge 1 commit into
integration/aurorafrom
deadweight/dcp-v27-sleep-params
Draft

RyanTheTide wants to merge 1 commit into
integration/aurorafrom
deadweight/dcp-v27-sleep-params

Conversation

@RyanTheTide

Copy link
Copy Markdown
Contributor

Problem

The T6050 firmware 27 sleep/wake sequence (dcp-v27-sleep.inc, iomfb.c) still has 17 module parameters left from its bring-up, one per step that was being tried. Their defaults are the sequence that shipped, and nothing we ship sets any of them. The other values are paths that never run.

Change

Freeze the sequence at its defaults and remove the parameters (net -86 lines):

  • On/off switches whose default was on: the step now always runs (v27_two_stage, v27_soft_first, v27_a115, v27_ext_a442, v27_ext_cycles, v27_ext_rounds, v27_session_rounds, v27_cycle_power, v27_cycle_pmc, v27_cycle_disp_rewrite, t6050_ext_services, v27_a442).
  • Switches whose default was off: the step is removed (v27_ext_a500_again, v27_sleep_power_oob with its always-false oob field, and v27_lit_delay_ms=0's pause branch).
  • v27_cycle_hold_ms becomes a named 12 ms constant with its old description.
  • v27_rtkit_cycles selected a mode (0-3). The default, one coprocessor restart, stays; the dark-wake modes 2 and 3 go.
  • The fallbacks for a DART that can't be found or stopped stay.
  • v27_keep_level stays, because a host test (apple-dcp/desktop.py) builds against it.

The sequence is DjDeveloperr's (5d46c24, 3ed9757, 69e7e75).

Testing

  • make drivers/gpu/drm/apple/ with the fleet config, before and after: RC=0, no warnings.
  • appledrm.o .modinfo: exactly these 17 parameters disappear.
  • 24 host tests that read the touched files: identical exit codes before and after.
  • Setter search as in the kill-switch PR: nothing sets any of these names.

Still to run

Assisted-by: LLM (Claude:Opus 5.5)

The firmware 27 sleep and wake sequence carries 17 bring-up switches
from its development (5d46c24, 3ed9757, 69e7e75):
v27_two_stage, v27_soft_first, v27_lit_delay_ms, v27_a115,
v27_ext_a442, v27_ext_a500_again, v27_ext_cycles, v27_ext_rounds,
v27_session_rounds, v27_cycle_power, v27_rtkit_cycles,
v27_cycle_hold_ms, v27_cycle_pmc, v27_cycle_disp_rewrite,
t6050_ext_services, v27_sleep_power_oob and v27_a442. Their defaults
are the sequence that shipped; nothing we ship sets any of them.

Remove them and the branches only their non-default values took.
v27_cycle_hold_ms becomes a named constant (12 ms) with its old
description. v27_rtkit_cycles picked a mode (0-3); the default mode,
one coprocessor restart, stays and the dark-wake modes 2 and 3 go.
The fallbacks for a DART that can't be found or stopped stay.
v27_keep_level is kept: a host test builds against it.

Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant