Repository navigation
asahi: give the 10-bit X2 formats the RGB10A2 end-of-tile selector - #282
Merged
Merged
Conversation
A multisampled EGL config resolves into its window buffer at the end of the render, and on G17P that store takes its per-target selector from agx_g17p_mrt_eot_selector(). The table listed the RGB10A2 formats but not their X2 spellings, so a multisampled B10G10R10X2 config got selector 0, its end-of-tile program failed to compile, and the driver aborted. dEQP-EGL's color_clears and render .other cases hit this at the first 2-sample X2 config. X2 and A2 share the same tile format; map X2 to 0x75 like A2. Signed-off-by: Diljit Singh <hey@djdev.me>
This was referenced Nov 13, 2026
Merged
Author
|
Gate evidence for merging #282 (batch1, step 7 of a tree-checked sequence):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the Neo (A18 Pro, G17P), 14 dEQP-EGL cases abort:
color_clears.{single_context,multi_context,multi_thread}.{gles2,gles3}.otherandrender.{…}.{gles2,gles3,gles2_gles3}.other. Each one aborts at the first multisampled 10-bit XRGB config, with:A multisampled EGL config resolves into its window buffer at the end of the render. On G17P that store-and-resolve end-of-tile program takes its per-target selector from
agx_g17p_mrt_eot_selector(). The table listedR10G10B10A2_UNORMandB10G10R10A2_UNORM(0x75) but not their X2 spellings. So a multisampledB10G10R10X2config got selector 0, the packer refused it, the end-of-tile program failed to compile, and the driver aborted.X2 and A2 use the same tile format, and the single-sample end-of-tile path already treats X2 as A2. That is why the single-sample XRGB2101010 configs pass. This change maps both X2 formats to 0x75 and adds the two checks to
test-agx-g17p-mrt-mixed.Evidence
batch1), which includes the 14 cases and the dEQP-EGL sample. I'll add the result here before merge.🤖 Generated with Claude Code