Repository navigation
hk: test G17P colour MSAA spill admission - #66
Closed
RyanTheTide wants to merge 1 commit into
Closed
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
Keep colour MSAA attachments plain until eMRT access can preserve their contents and compression metadata. Even a small attachment can spill next to wide targets, and stored LOAD attachments and multiview use a narrower tilebuffer allocation. An image's own footprint cannot prove lifetime spill safety. Enumerate every allocator footprint sequence at 1x/2x/4x under both limits and layer shapes. Require every attachment in a spilling pass to be plain, including resident targets. Cover all admitted colour formats in the allocation policy and provide an offline CLI for probing individual mixes.
RyanTheTide
added a commit
that referenced
this pull request
Oct 26, 2026
Reuse the public Gen9 layered/MSAA packet and per-level ZLS work from Mesa PRs #65 and #67 on the admitted T6040 profile. Its AGX3B, HAL200, Gen9 descriptor and sampler axes match the native profile established by #55. Select expanded array/cube/3D colour, transfer-only 2x/4x colour, layered/MSAA depth-stencil and single-sample depth-stencil mip policies by the physical T6040 identity. Preserve the prior Neo policy and Gen10 packet cases. Colour MSAA render attachments stay plain under #66 because a legal MRT mix can spill them; #72 adds unmeasured boundary-copy work and is not silently enabled. Keep all source-level RT gates unchanged. Retain existing policy regressions and add the public packet, metadata and per-level ZLS checks alongside a separate G16S policy suite. Hardware and performance qualification remain required before merge. Source: #65 Source: #67 Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
RyanTheTide
added a commit
that referenced
this pull request
Oct 26, 2026
Reuse #66 allocation-policy coverage across all46 admitted colour formats, sample/layer counts and input/transient attachment combinations. Transfer-only compressed MSAA must not make any later legal colour-attachment spill depend on an unavailable decompression path. Source: #66 Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Author
|
Superseded by #87, merged into aurora-wip in the 2026-10-28 consolidation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small colour MSAA attachments can spill beside wide targets, and stored LOAD attachments or multiview use a narrower tilebuffer allocation. G17P has no in-place decompression kernel for the raw eMRT path, so keep colour MSAA render attachments plain. The existing single-sample UNORM8 compute mip path does not establish a general MSAA conversion.
Add an exhaustive allocator footprint matrix for 1x/2x/4x and both layer shapes under both applicable limits. It checks every attachment in a spilling pass, including resident targets. Expand allocation-policy coverage to all 46 admitted colour formats and add a CPU-only CLI to inspect individual attachment mixes. Allocation logic and the M1/M2 paths are unchanged.
Stacks on #65.
Validation