Skip to content

hk: copy the external-memory info out of image create chains - #96

Merged
DjDeveloperr merged 1 commit into
aurora-wipfrom
fix/hk-chain-copy-external
Oct 29, 2026
Merged

DjDeveloperr merged 1 commit into
aurora-wipfrom
fix/hk-chain-copy-external

Conversation

@DjDeveloperr

Copy link
Copy Markdown

Follow-up to #95, from maralcbr's review of omacom#19. omacom's integration branch reads VkExternalMemoryImageCreateInfo::handleTypes in the G17P chain walk with a memcpy into a local instead of a cast of the chain pointer. This uses that form in the G17P walk and in the M5 colour and depth walks, so both trees carry the same code. Testing (host): hk_g17p_compression_test passes all 4069 checks; hk_image.c, hk_cmd_draw.c and hk_g17p_meta_copy_core.c build with -Dwerror=true.

The image-create chain walks in hk_g17p_compression.h read
VkExternalMemoryImageCreateInfo::handleTypes through a cast of the chain
pointer. omacom/mesa's integration branch already reads it with a
memcpy into a local, and reads the next pointer before looking at the
structure. Use that form in the G17P walk and in the M5 colour and
depth walks, so the walks don't access the chain through another
structure's type and both trees carry the same code.

hk_g17p_compression_test: 4069 checks pass.
@DjDeveloperr
DjDeveloperr merged commit e45470f into aurora-wip Oct 29, 2026
@RyanTheTide
RyanTheTide deleted the fix/hk-chain-copy-external branch October 30, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant