Clean up eslint findings and enforce lint on PRs - #60
Merged
Merged
Conversation
Replace the dev-only console.warn with an error toast so users actually see when glyphs did not fit in the atlas.
PaddingFields and SpacingFields each declared an identical pixel input component. Consolidate into a single PixelInput module.
Narrow Slider onValueChange via typeof instead of Array.isArray so TS keeps the union narrowed (Array.isArray widens to any[]), and add the blank lines required by padding-line-between-statements in main.
Adds a lint job that runs on pull_request to main. ESLint exits non-zero on any error, failing the check so the PR cannot be merged once the new check is marked required in the branch ruleset.
aurpelai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warnfor atlas overflow with a user-visible error toast (fix:— behaviour change)PaddingFieldsandSpacingFieldsinto a sharedPixelInputSlideronValueChangeviatypeof === 'number'so TS keeps the union narrowed (Array.isArraywidens toany[])padding-line-between-statementsrequires inmain.tsxCIworkflow that runspnpm linton every pull request tomain; thelintcheck is now required by the "Protect main" ruleset, blocking merges on lint errorsTest plan
pnpm lintis cleanpnpm buildsucceedslintjob runs on this PR and passes