Skip to content

Keep hint searches off the main actor - #106

Merged
austin-smith merged 2 commits into
mainfrom
make-hints-responsive
Sep 15, 2026
Merged

austin-smith merged 2 commits into
mainfrom
make-hints-responsive

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

Move hint searches into a session-owned actor that preserves planner caches. Add cooperative cancellation to all ten planners, reject stale results, and save hint usage when a result arrives.

Why

Hint searches could occupy the main actor for up to half a second. Searching in the background keeps gameplay responsive while protecting the current board and statistics from obsolete results.

UI Changes

Disable the Hint button and menu command while a search is pending. Other gameplay remains available and cancels the pending hint when the board changes.

Validation

  • macOS and iOS simulator builds passed.
  • Full macOS suite: 609 tests passed; 10 opt-in screenshot fixture generators skipped. Includes 12 new tests covering cancellation, stale results, session transitions, and cleanup.
  • Autoreview returned clean; diff checks passed.

Depends on #105; targets its branch to keep this diff focused on hint responsiveness.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T23:16:57.245184Z 3adc472 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Base automatically changed from fix-pixel-shape-isolation to main September 15, 2026 23:24
@austin-smith
austin-smith merged commit 5c7c300 into main Sep 15, 2026
3 checks passed
@austin-smith
austin-smith deleted the make-hints-responsive branch September 15, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant