Add fastlane screenshot automation - #31
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8356ec8878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <TestableReference | ||
| skipped = "NO"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "4B75C1F62F1A233600761A12" | ||
| BuildableName = "ComputerSolitaireUITests.xctest" | ||
| BlueprintName = "ComputerSolitaireUITests" |
There was a problem hiding this comment.
The documented test workflow runs xcodebuild ... -scheme ComputerSolitaire ... test, and this new TestableReference makes every normal test run execute ScreenshotCaptureUITests, which launches the app for each staged board and captures screenshots. That should stay isolated to ComputerSolitaireScreenshots; otherwise ordinary unit-test/CI runs become UI-automation dependent, slower, and more likely to fail in non-interactive environments.
Useful? React with 👍 / 👎.
| #if canImport(UIKit) | ||
| import UIKit | ||
| #endif | ||
| #if canImport(AppKit) | ||
| import AppKit |
There was a problem hiding this comment.
The repository instructions in AGENTS.md mark the SwiftUI-only contract as non-negotiable and explicitly say not to add UIKit or AppKit usage. This new UI test target imports both frameworks and then uses types like UIDevice, NSScreen, and NSBitmapImageRep, so it violates the project platform contract unless maintainers explicitly grant an exception.
Useful? React with 👍 / 👎.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
Add fastlane screenshot capture workflow: