Skip to content

Add SwiftLint CI enforcement - #37

Closed
austin-smith wants to merge 2 commits into
mainfrom
swiftlint
Closed

austin-smith wants to merge 2 commits into
mainfrom
swiftlint

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • Added a project SwiftLint configuration covering the app, unit tests, and UI tests.
  • Added a checksum-verified SwiftLint 0.65.0 CI job that gates the macOS test and iOS build jobs.
  • Configured the 800-line warning and 1,000-line error thresholds, curated safety-focused opt-in rules, and two temporary file_length exceptions.
  • Refactored existing violations in place so strict lint completes cleanly without a baseline or broad source exclusions.

Why

Automated linting provides consistent code-quality enforcement in CI without coupling local Xcode builds to a developer tool installation.

The remaining oversized-file cleanup is tracked in #36.

Validation

  • SwiftLint 0.65.0 strict lint: 0 violations across 75 files
  • macOS build passed
  • iOS Simulator build passed
  • macOS test suite: 87 passed, 2 skipped, 0 failed

@austin-smith
austin-smith marked this pull request as ready for review July 11, 2026 23:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8467adfdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .swiftlint.yml
@austin-smith

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 9d6f2b1713

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@austin-smith
austin-smith deleted the swiftlint branch July 12, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant