Reorganize toolbars - #62
Merged
Merged
Conversation
ios: more menu absorbs game flow and app chrome in sections; hint and undo stay top level; auto finish appears as a contextual pill only while the game is finishable. macos: same contextual auto button, undo/hint grouped, new game and redeal collapse into a menu, stats and settings pair at the trailing edge. add haptics for starting auto finish and for every live win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
iOS bottom bar
ellipsis) now holds everything non-gameplay, in sections: New Game/Redeal, Statistics/Rules & Scoring, SettingsisAutoFinishAvailable; Statistics and Settings no longer occupy top-level slotsmacOS toolbar
+menuHaptics
autoFinishStart(impact, fired on starting auto finish) andgameWon(success, fired on every live win — manual, auto finish, and Golf hole clears; suppressed during game hydration)Why
The previous bars mixed three kinds of actions — in-game moves, game flow, and app chrome — in one flat row with no hierarchy, and buried time-sensitive actions (Hint, Auto Finish) behind a menu on iOS while rarely-used ones (Statistics, Settings) held top-level slots. Placement now follows frequency of use, and Auto Finish's presence itself signals the moment a win becomes mechanical instead of idling as a disabled button. Wins previously had no haptic feedback at all.
Validation
xcodebuild ... -destination 'platform=macOS' test— all suites green)UI Changes
⋯menu · (Auto when finishable) · Hint · Undo+menu · Stats | Settings