Standardize settings and add native macOS settings window - #66
Merged
Merged
Conversation
reorganize settings into appearance, sound & haptics, gameplay, help, and about sections with live previews on appearance rows. add haptic feedback, show game stats, and show stock count settings. replace nested sheets with navigation pushes and give the macos sheet a navigation stack.
replace the macos settings sheet with a settings scene: general, appearance, rules, and about panes with fitted sizes so pane switches get the system's animated resize. share settings rows between the ios sheet and the panes, add a game picker to rules & scoring, and wrap the about copy to the about window's column width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
HapticManager, the stats strip hides as a whole (including Golf's Match tile), and stock counts hide in both stock presentations while accessibility values keep reporting exact counts.Settingsscene: General, Appearance, Rules, and About panes with fitted sizes, so ⌘, opens the standard settings window and pane switches get the system's animated resize.SoundSettingsRows,GameplaySettingsRows,TableSettingsRows,CardsSettingsRows).Why
The settings page had grown into a flat list with uneven sections, nested sheets, and no macOS-native behavior — resizing the sheet on every navigation with no animation. This restructures it around standard platform patterns and adds the three requested visibility/feedback settings (#54, #55, #57).
Validation
UI Changes
Closes #54, closes #55, closes #57.