Make the game picker's overflow read as scrollable - #68
Merged
Merged
Conversation
ten families overflow a phone screen, and the picker's scroll fallback clipped mid-row with no cue that more games sat below the fold. fade whichever edges hide more content and land on the current game when the picker opens, so the overflow reads as scrollable instead of broken.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
onScrollGeometryChange, so the fold reads as "scroll for more" instead of an accidental mid-row clip.Why
With ten game families, the gallery overflows a phone screen. The existing
ViewThatFitsfallback scrolled correctly but gave no cue that it did: the panel clipped Forty Thieves mid-row with no fade or indicator, so the games below the fold — including the newest variants — looked cut off rather than reachable. This also scales to future variants without revisiting the layout.Validation
UI Changes