Skip to content

Make the game picker's overflow read as scrollable - #68

Merged
austin-smith merged 1 commit into
mainfrom
game-picker-scroll-affordances
Jul 14, 2026
Merged

austin-smith merged 1 commit into
mainfrom
game-picker-scroll-affordances

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • The game picker's scrolling fallback now fades the content at whichever panel edges hide more of it, driven by onScrollGeometryChange, so the fold reads as "scroll for more" instead of an accidental mid-row clip.
  • When the picker opens in its scrolling state, it scrolls the current game just into view; an already-visible selection stays put.
  • The non-scrolling presentation (windows tall enough to fit every family) is unchanged, as are the family rows themselves.

Why

With ten game families, the gallery overflows a phone screen. The existing ViewThatFits fallback scrolled correctly but gave no cue that it did: the panel clipped Forty Thieves mid-row with no fade or indicator, so the games below the fold — including the newest variants — looked cut off rather than reachable. This also scales to future variants without revisiting the layout.

Validation

  • Full test suite on macOS: 541 tests, 0 failures.
  • Debug builds succeed for iOS simulator and macOS destinations.
  • Verified on the iPhone 17 Pro simulator: bottom fade on open, fade handoff between edges while scrolling, fades releasing at either end, and the picker opening scrolled to Canfield when Canfield is the current game.

UI Changes

  • Scrolling picker only: 24pt gradient fades at overflowing panel edges (0.15s ease as they engage/release), and the initial scroll position lands on the current game. No changes to row layout, spacing, or the fits-without-scrolling presentation.

ten families overflow a phone screen, and the picker's scroll
fallback clipped mid-row with no cue that more games sat below
the fold. fade whichever edges hide more content and land on
the current game when the picker opens, so the overflow reads
as scrollable instead of broken.
@cursor

cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@austin-smith
austin-smith merged commit 26e45af into main Jul 14, 2026
2 checks passed
@austin-smith
austin-smith deleted the game-picker-scroll-affordances branch July 14, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant