Skip to content

Keep screenshot fixtures in sync - #69

Merged
austin-smith merged 2 commits into
mainfrom
keep-screenshot-fixtures-in-sync
Jul 14, 2026
Merged

austin-smith merged 2 commits into
mainfrom
keep-screenshot-fixtures-in-sync

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • Added a shared screenshot fixture catalog used by both the app and UI test targets.
  • Updated screenshot capture to cover all ten bundled game fixtures.
  • Removed inconsistent “fresh deal” fixture metadata while preserving meaningful mode qualifiers.
  • Refreshed the tracked iOS and macOS README screenshots.

Why

The screenshot UI test duplicated the app’s fixture list and had fallen out of sync, so only four of ten game variants were captured. Sharing one ordered catalog prevents that drift.

Validation

  • Ran the macOS test suite: 541 tests passed with 0 failures; 10 fixture generators skipped as designed.
  • Built the macOS app successfully.
  • Ran dark-mode Fastlane capture on iPhone 17 Pro Max and iPhone 17 Pro.
  • Verified 20 generated PNGs at the expected dimensions.
  • Visually reviewed the newly included game screenshots.
  • Ran git diff --check.

UI Changes

Updated the tracked iOS and macOS screenshots to reflect the current dark appearance.

@austin-smith
austin-smith marked this pull request as ready for review July 14, 2026 19:21
@cursor

cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@austin-smith
austin-smith marked this pull request as draft July 14, 2026 19:21
@austin-smith
austin-smith marked this pull request as ready for review July 14, 2026 19:34
@austin-smith
austin-smith merged commit 43aa9ce into main Jul 14, 2026
2 checks passed
@austin-smith
austin-smith deleted the keep-screenshot-fixtures-in-sync branch July 14, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant