host the bottom bar in a navigation stack - #85
Closed
austin-smith wants to merge 1 commit into
Closed
austin-smith wants to merge 1 commit into
austin-smith wants to merge 1 commit into
Conversation
The iOS bottom bar had no navigation host: ContentView sits bare in the WindowGroup, so `.bottomBar` items were bridged onto the window root and board mutations tore them down — the bar visibly blanked and returned on every stock draw. It also left `.toolbar(_:for: .bottomBar)` inert, which is why picker visibility was faked by emptying the item list. Wrap the board in a NavigationStack that only ever hosts (never pushes, own navigation bar hidden), and drive picker visibility through the real visibility API. The stack adds a subtree that is measured before layout and reports a frame with a real origin but no size, e.g. (148, 0, 0 x 0). The single-frame preference keys rejected only `.zero`, so that candidate passed the guard and clobbered the live stock/waste frames — every card flight then launched from the top of the screen instead of the pile. Guard on size instead, which is what the check meant all along. Verified the flight planner's inputs are unchanged with the stack in place: stock (12, 114.667, 47 x 68.15) and waste (67, 114.667, 63.92 x 68.15) match the pre-change build exactly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed and superseded. Original description removed.