Skip to content

Improve pixel pip sprites - #88

Merged
austin-smith merged 1 commit into
mainfrom
improve-pixel-pip-sprites
Aug 8, 2026
Merged

austin-smith merged 1 commit into
mainfrom
improve-pixel-pip-sprites

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • Reshaped the compact spade, heart, and club pip sprites used on numbered cards in the Pixel style.
  • Documented the horizontal-symmetry invariant for compact pip artwork.

Why

The compact heart pip had a horizontally offset top row, and the spade and club silhouettes were less clear when reused for the 180-degree-rotated lower pips. Centering each row keeps the symbols visually consistent in both orientations.

UI Changes

Numbered cards using the Pixel style now show clearer, centered spade, heart, and club pips. The diamond pip, aces, corner indices, face cards, card backs, and other card styles are unchanged.

Validation

  • macOS test suite: 594 tests executed, 10 skipped, 0 failures
  • git diff --check
  • Structured review reported no actionable findings

@austin-smith
austin-smith marked this pull request as ready for review August 8, 2026 21:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf09ea3bcb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ComputerSolitaire/Views/Cards/Styles/PixelCardViews.swift
@austin-smith
austin-smith merged commit 6f0c694 into main Aug 8, 2026
3 checks passed
@austin-smith
austin-smith deleted the improve-pixel-pip-sprites branch August 8, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant