Skip to content

Use suit glyphs for Simple royal cards - #89

Merged
austin-smith merged 4 commits into
mainfrom
use-suit-glyphs-for-royal-cards
Aug 9, 2026
Merged

austin-smith merged 4 commits into
mainfrom
use-suit-glyphs-for-royal-cards

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • Removed the Simple card style's royal-art rendering path.
  • Rendered jacks, queens, and kings with the same centered suit glyph used by other ranks.
  • Kept all royal PNG assets intact for possible future use.

Why

The current royal artwork is being deferred until a later iteration. Using the established suit-glyph treatment keeps the Simple card style visually consistent in the meantime.

UI Changes

Simple royal cards now show the existing large centered suit glyph instead of the royal PNG artwork. The split rank-and-suit corner layout remains unchanged.

Validation

  • macOS Debug build succeeded with the generic macOS destination.
  • git diff --check passed.
  • Autoreview reported no accepted or actionable findings.

@austin-smith
austin-smith force-pushed the use-suit-glyphs-for-royal-cards branch from faff54f to b25f9e1 Compare August 9, 2026 02:23
@austin-smith
austin-smith marked this pull request as ready for review August 9, 2026 02:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6672d7dda4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ComputerSolitaire/Views/Cards/CardView.swift
@austin-smith

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 722a4fc055

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@austin-smith
austin-smith merged commit 8c0db39 into main Aug 9, 2026
3 checks passed
@austin-smith
austin-smith deleted the use-suit-glyphs-for-royal-cards branch August 9, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant