Unify the product tagline and put it on the playback splash - #39
Merged
Merged
Conversation
the root command described itself two ways depending on whether stdout was a tty: commander printed "Spotify in your terminal" while the clack banner printed "spotify in ur terminal". the homebrew formula carried a third variant. define the tagline once in the cli presenter and derive the npm description and the formula desc from it. the desc is deliberately lowercase; brew audit warns on a lowercase-initial desc, but this is a personal tap and the tagline is the brand. drop the desc assertion from the tap test, which restated the constant inside a test about platform binary selection.
the empty-playback splash has the most dwell time, so it carries the tagline under the wordmark. the existing message row is untouched — every state of it is status or a keybinding hint. the tagline costs two rows, its own plus a blank one, and is dropped whole whenever those rows would move the wordmark or overflow the region. swap the wordmark art from the block font to tiny. six rows dominated the screen, and needing 70 columns meant anything narrower fell all the way back to plain text; two rows and 29 columns keep real brand art down to ~33 columns. rename the lockup mode from block to art to match. split the art into three segments so the tui in spo·tui·fy carries the mark's cream. the segments plus their gaps total exactly the width one call produced. move the tagline constant to src/branding.ts now that the tui needs it too; importing the cli presenter from the ui would drag clack into the tui.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 872b725217
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
the mode check is pure layout math, so a re-split of the segments or a font swap could keep it green while the lockup box clipped the right edge of the art. the 29-column breakpoint is derived from gaps the font inserts internally, which nothing was verifying against a real render.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--helpdescription, npm description, and Homebrewdescfrom one constant insrc/branding.tsblockfont totiny, and rename the lockup mode to matchdocs/assets/spotuify-logo.pngWhy
The root command described itself two ways depending on whether stdout was a TTY, and the Homebrew formula carried a third variant. The tagline also never appeared in the app itself.
The
tinyart is two rows instead of six and needs 29 columns instead of 70, so brand art now survives on terminals that previously fell back to plain text, including the startup error screen when a diagnostic wraps. The tagline is dropped whole whenever its rows would move the wordmark or overflow the splash region.Validation
bun run typecheckbun test— 1,040 passed--versionoutput unchanged;scripts/verify-npm.tsandscripts/verify-release.tsexact-match it