Skip to content

Fix Windows installer entrypoint execution - #41

Merged
austin-smith merged 1 commit into
mainfrom
windows-installer-entrypoint
Aug 4, 2026
Merged

austin-smith merged 1 commit into
mainfrom
windows-installer-entrypoint

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • replace invocation-context detection with an explicit -LoadOnly switch for installer unit tests
  • run the public Windows installer smoke test in a clean Windows PowerShell process
  • add regression coverage for evaluation from a dot-sourced scope and for the release workflow command

Why

The v0.2.0 release smoke test evaluated the downloaded installer inside GitHub Actions' dot-sourced PowerShell scope. $MyInvocation.InvocationName was therefore ., so the installer silently skipped Install-Spotuify and the workflow failed when it looked for the missing executable.

Failed run: https://github.com/austin-smith/spotuify/actions/runs/30894354563/job/91947662940

Validation

  • bun test — 1,041 passed
  • bun run typecheck
  • bun run installer:test:posix — 19 passed
  • focused release workflow tests — 3 passed
  • structured autoreview — clean
  • git diff --check

@austin-smith
austin-smith merged commit 1e3d7f7 into main Aug 4, 2026
5 checks passed
@austin-smith
austin-smith deleted the windows-installer-entrypoint branch August 4, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant