Skip to content

build: add legacy-peer-deps to .npmrc - #1036

Closed
yogeshchoudhary147 wants to merge 1 commit into
mainfrom
fix/legacy-peer-deps
Closed

yogeshchoudhary147 wants to merge 1 commit into
mainfrom
fix/legacy-peer-deps

Conversation

@yogeshchoudhary147

@yogeshchoudhary147 yogeshchoudhary147 commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Dependabot's npm skips optional peer deps when generating lockfiles, causing npm ci to fail on dependabot PRs. Adding legacy-peer-deps=true aligns our npm behavior with dependabot's so both generate consistent lockfiles.

Summary by CodeRabbit

  • Chores
    • Updated npm configuration to use legacy peer dependency handling during package installation.

@yogeshchoudhary147
yogeshchoudhary147 requested a review from a team as a code owner September 12, 2026 02:46
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 58f8e95b-a69b-4e97-8a9e-8e89fe5d0cf1

📥 Commits

Reviewing files that changed from the base of the PR and between d3886a9 and c12621d.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • .npmrc

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The .npmrc file enables npm legacy peer dependency resolution.

Changes

npm configuration

Layer / File(s) Summary
Legacy peer dependency resolution
.npmrc
Adds legacy-peer-deps=true to the npm configuration.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: amitsingh05667

Merge Risk: ⚪ Minimal · up to c1262

This change aligns local and Dependabot dependency installation behavior without an identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the legacy-peer-deps setting to .npmrc.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/legacy-peer-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yogeshchoudhary147
yogeshchoudhary147 deleted the fix/legacy-peer-deps branch September 15, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant