Skip to content

build: add @noble/hashes as devDependency - #1041

Merged
yogeshchoudhary147 merged 1 commit into
mainfrom
fix/noble-hashes-override
Sep 14, 2026
Merged

yogeshchoudhary147 merged 1 commit into
mainfrom
fix/noble-hashes-override

Conversation

@yogeshchoudhary147

@yogeshchoudhary147 yogeshchoudhary147 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the npm overrides workaround with an explicit @noble/hashes@^2.0.0 devDependency
  • Fixes Dependabot PRs failing with Missing: @noble/hashes@2.4.0 from lock file since Dependabot skips optional peer deps when regenerating the lockfile

Test plan

  • CI passes on this PR
  • Verify Dependabot PRs pass after this merges

Summary by CodeRabbit

  • Chores
    • Added a development dependency to support project tooling.

@yogeshchoudhary147
yogeshchoudhary147 requested a review from a team as a code owner September 14, 2026 12:47
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b517a1f7-42bc-4a45-8c71-0b3886a126c9

📥 Commits

Reviewing files that changed from the base of the PR and between 3f4aea1 and 466a88f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The package configuration adds @noble/hashes version ^2.0.0 to the development dependencies.

Changes

Development dependency update

Layer / File(s) Summary
Add hashing development dependency
package.json
Adds @noble/hashes version ^2.0.0 to devDependencies.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: frederikprijck

Merge Risk: ⚪ Minimal · up to 8a4ca

The dependency update is compatible with the repository’s exercised Node versions and has no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: adding @noble/hashes as a development dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/noble-hashes-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yogeshchoudhary147
yogeshchoudhary147 merged commit aa7207e into main Sep 14, 2026
12 of 13 checks passed
@yogeshchoudhary147
yogeshchoudhary147 deleted the fix/noble-hashes-override branch September 14, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants