Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will change the way the increased timeout for the
AWS.EC2MetadataCredentialsis set.Currently this library is hard overriding anything that might have been set as the credentials source by the surrounding application and/or environment.
It makes it impossible to provide credentials via a configuration file in
~/.awsor environment variables not only for the kinesis stream writer but for the whole application using theKinesisStreamclass.This behaviour was introduced by removing the configuration gate
params.getCredentialsFromIAMRolehereA minimal demo for the problem using environment variables: