Adding success event when the putRecords call on kinesis returns data with no errors.#47
Open
menarguez wants to merge 1 commit intoauth0:masterfrom
Open
Adding success event when the putRecords call on kinesis returns data with no errors.#47menarguez wants to merge 1 commit intoauth0:masterfrom
menarguez wants to merge 1 commit intoauth0:masterfrom
Conversation
… with no errors. PR Changes: - Added unit tests - Updated README.md - Added success event trigger when the callback to putRecords returns with no errors, but valid data object
a63bfa6 to
318344b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Changes:
Description
This PR adds a success event that will be triggered on a successful write of putRecords if no errors were present
Testing
Unit tests, local testing.
outputs
Checklist
master