fix: don't change working dir - #4
Open
mastermatt wants to merge 1 commit into
Open
Conversation
Pass the absolute path of the XSD to `xmllint` instead of changing the cwd of the entire Node process. Also updated .npmignore to include the index.d.ts and not double include the schamas in the pack. Fixes authenio#2, fixes authenio#3
|
@mastermatt has this not been pushed? |
boncz92
approved these changes
Dec 17, 2023
boncz92
left a comment
boncz92
left a comment
There was a problem hiding this comment.
This is causing issues in nextjs 14 and I see no issues with the changes made.
Author
No. I had to abandon this lib in my project because of this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the absolute path of the XSD to
xmllintinstead of changing the cwd of the entire Node process.Also updated .npmignore to include the index.d.ts and not double include the schamas in the pack.
Fixes #2, fixes #3
@tngan